Hello,

Thanks for the additional pointers.  I'll dig into this soon.

-- 
Sean Whitton

Hello,

On Fri 02 Aug 2024 at 11:28pm -05, Dan Carpenter wrote:

> *You* need to figure out what the proper thing is.  Not us.  That's the
> difficult part of writing a patch.  Once you know what the correct thing
> is, then the rest is just typing.
>
> That business of defining STORAGE_CLASS_SP_C is weird.  Figure out the
> authors intention and find a better way to do it.
>
> Figure out why your code compiled as well because putting parentheses
> around (static inline) is a syntax error.

Hello,

On Tue 30 Jul 2024 at 08:38am +02, Greg Kroah-Hartman wrote:

> This isn't a "complex values", and really should just be removed
> entirely and use the correct "static inline" properly.

I found that there are several headers in
atomisp/pci/hive_isp_css_include which have this pattern of defining an
_INLINE_*_ preprocessor constant, and using it to choose between
'extern' and 'static inline' in each file where the header is included.

I don't know what the author's intention was.  Are you saying that you
think this preprocessor mechanism should just be replaced with

Fix checkpatch error
"ERROR: Macros with complex values should be enclosed in parentheses"
at hive_isp_css_include/sp.h:41, hive_isp_css_include/sp.h:42.

Signed-off-by: Sean Whitton <spwhitton@spwhitton.name>
---
 drivers/staging/media/atomisp/pci/hive_isp_css_include/sp.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

This is my first Linux kernel patch, from Helen Koike's DebConf24 workshop.
Thanks!

diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_include/sp.h b/drivers/staging/media/atomisp/pci/hive_isp_css_include/sp.h
index a7d00c7bb8bc..128109afe842 100644
[message trimmed]

Hello,

On Tue 20 Sep 2022 at 05:15AM +03, Protesilaos Stavrou wrote:

> I tried it.  It works.  However, it does not get captured by the
> tab-bar, which reminded me why I picked global-mode-string in the first
> place.

Maybe upstream Emacs should be changed to include it in the tar bar.

-- 
Sean Whitton

Hello,

On Mon 19 Sep 2022 at 08:15PM +03, Protesilaos Stavrou wrote:

>> From: Sean Whitton <spwhitton@spwhitton.name>
>> Date: Mon, 19 Sep 2022 09:22:36 -0700
>>
>> Hello,
>
> Hi Sean,
>
>> On Mon 19 Sep 2022 at 12:00AM GMT, Protesilaos Stavrou: Coding blog: <author> wrote:
>>
>>> I have just pushed the first commits to the `notmuch-indicator` Git

Hello,

On Mon 19 Sep 2022 at 12:00AM GMT, Protesilaos Stavrou: Coding blog: <author> wrote:

> I have just pushed the first commits to the `notmuch-indicator` Git
> repository: <https://git.sr.ht/~protesilaos/notmuch-indicator>. This
> provides a global minor mode—`notmuch-indicator-mode`—that puts the
> return value of `notmuch count` commands on the Emacs mode line.
> Technically, it appends it to the `global-mode-string`, so it also works
> with the built-in `tab-bar-mode`.

How about using mode-line-misc-info instead of global-mode-string?

--

The first argument to `notmuch-show' is documented to be a notmuch thread ID,
not a notmuch query.  If you pass a query then the buffer-local variable
`notmuch-show-thread-id' is populated with a value that is not a thread ID,
which breaks various other things.

`org-notmuch-follow-link' should continue to accept an arbitrary notmuch
query, because notmuch thread IDs are not stable.
---
 ol-notmuch.el | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Notmuch thread IDs look like 'thread:000000000000f4a2'.

Previous discussion: https://list.orgmode.org/87h82wrjvb.fsf@iris.silentflame.com/
[message trimmed]

Hello Theodor,

On Tue 21 Dec 2021 at 07:30PM +01, Theodor Thornhill wrote:

> Actually, I think that running Sourcehut as a local instance wouldn't
> really be necessary for the evaluation, because it is the same code that
> is running on sr.ht.  Apart from the fiddly bits with self hosting, the
> workflow should be the same.  I'd encourage people on this list getting
> their own user there and trying it out, as I think many already have.
> Specifically, emacs-devel would want to use the `meta`, `lists`, `git`,
> `todo` and `builds` subprojects, that is all apart from the `hg` one.

How about just setting up meta, lists and builds, leaving debbugs and
savannah doing bug tracking and git hosting, and then add 'todo' and

Hello Theodor,

On Tue 21 Dec 2021 at 07:30PM +01, Theodor Thornhill wrote:

> Actually, I think that running Sourcehut as a local instance wouldn't
> really be necessary for the evaluation, because it is the same code that
> is running on sr.ht.  Apart from the fiddly bits with self hosting, the
> workflow should be the same.  I'd encourage people on this list getting
> their own user there and trying it out, as I think many already have.
> Specifically, emacs-devel would want to use the `meta`, `lists`, `git`,
> `todo` and `builds` subprojects, that is all apart from the `hg` one.

How about just setting up meta, lists and builds, leaving debbugs and
savannah doing bug tracking and git hosting, and then add 'todo' and