Marked as superseded !

Marked as applied

> diff --git a/scripts/modem/sxmo_modemsendsms.sh b/scripts/modem/sxmo_modemsendsms.sh
> index 50b354d..f89ae90 100644
> --- a/scripts/modem/sxmo_modemsendsms.sh
> +++ b/scripts/modem/sxmo_modemsendsms.sh
> @@ -156,6 +156,12 @@ if [ "$(printf %s "$NUMBER" | xargs pn find | wc -l)" -gt 1 ] || [ -f "$SXMO_LOG
>  	sxmo_mms.sh processmms "$MESSAGE_PATH" "Sent"
>  	[ -f "$SXMO_LOGDIR/$NUMBER/draft.attachments.txt" ] && rm "$SXMO_LOGDIR/$NUMBER/draft.attachments.txt"
>  
> +	MMS_ID="$(echo "$MESSAGE_PATH" | rev | cut -d'/' -f1 | rev)"
> +	CONTACTNAME="$(sxmo_contacts.sh --name "$NUMBER")"
> +	[ "$CONTACTNAME" = "???" ] && CONTACTNAME="$NUMBER"

Is it possible to move those CONTACTNAME before to deduplicate those lines?

As I think about this, I still got some concerns

This notification monitor script trigger notification for other things
than modem notification. We dont really want to always use the first
word as summary.

So my recommendation would be to instead tweak sxmo_notificationwrite.sh
to add a new line that we will use here as summary. This give more
control to the caller (modem monitor) to the summary.

Another thing I got in mind is that we should probably specify a appname
from this monitor. -a notification_monitor by example would allow us to
customize this kind of sxmo notification.

Thanks! Applied with minor change

To git@git.sr.ht:~mil/sxmo-utils
   78c3767..1e8bdbb  master -> master

Thanks!

To git@git.sr.ht:~mil/sxmo-utils
   78c3767..1e8bdbb  master -> master

Marked as superseded !

Marked as superseded !

Marked as superseded !

Marked as superseded !