~stappers/dnsmasqmlpc

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch

[PATCH] dhcp.c: Updated comment lines

Details
Message ID
<20241005131956.18221-1-stappers@stappers.nl>
DKIM signature
missing
Download raw message
Patch: +4 -2
Reflect outcome of discussion on mailinglist.
Removed reference to meanwhile removed KB, Knowledge Base, note.
---
 src/dhcp.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/dhcp.c b/src/dhcp.c
index b65facd..e34b292 100644
--- a/src/dhcp.c
+++ b/src/dhcp.c
@@ -824,8 +824,10 @@ int address_allocate(struct dhcp_context *context,
	    /* Addresses which end in .255 and .0 are broken in Windows even when using 
	       supernetting. ie dhcp-range=192.168.0.1,192.168.1.254,255,255,254.0
	       then 192.168.0.255 is a valid IP address, but not for Windows as it's
	       in the class C range. See  KB281579. We therefore don't allocate these 
	       addresses to avoid hard-to-diagnose problems. Thanks Bill. */	    
	       in the class C range. We therefore don't allocate these addresses
	       to avoid hard-to-diagnose problems. Thanks Bill. Years later, in 2024,
	       was reverting the change reconsidered. The outcome was to leave it in.
	       https://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/2024q3/017747.html */
	    if (!d &&
		!lease_find_by_addr(addr) && 
		!config_find_by_address(daemon->dhcp_conf, addr) &&
-- 
2.30.2
Reply to thread Export thread (mbox)