~taiite

France

http://taiite.srht.site/

~taiite/public-inbox

Last active 2 hours ago
View more

Recent activity

Re: [PATCH senpai v5] MONITOR user with whom we have an open buffer 2 hours ago

From to ~taiite/public-inbox

> diff --git a/irc/session.go b/irc/session.go
> index b6d5873..7d3f166 100644
> --- a/irc/session.go
> +++ b/irc/session.go
> @@ -71,10 +71,11 @@ const (
>  	TypingDone
>  )
>  
> -// User is a known IRC user (we share a channel with it).
> +// User is a known IRC user.
>  type User struct {
> -	Name *Prefix // the nick, user and hostname of the user if known.
> -	Away bool    // whether the user is away or not
> +	Name         *Prefix // the nick, user and hostname of the user if known.

Re: [PATCH senpai 2/2] Add support for running on the web, connecting to websockets a day ago

From to ~taiite/public-inbox

Time to deprecate gamja i guess?

Jokes aside, nice project, this looks cool (and it works? it seems so)
I think you should set this up in a new repo with a Makefile and the HTML/JS boilerplate.

I don't have a lot of ideas about the text vs binary websocket issue..
What happens when you don't negotiate any sub-protocols?
It might also be possible for soju to accept the binary sub-protocol.

> @@ -346,6 +357,13 @@ func (app *App) tryConnect() (conn net.Conn, err error) {
>  	return
>  }
>  
> +func (app *App) tryConnectWebSocket() (net.Conn, error) {

Re: [PATCH senpai v4] MONITOR user with whom we have an open buffer a day ago

From to ~taiite/public-inbox

*sending this message from alps, sorry if it does not render properly*

Thanks for the patch. I can't test it right now, but at a glance you might need to rebase on latest master.

> @@ -130,6 +132,7 @@ type Session struct {
>  	chReqs         map[string]struct{}     // set of targets for which history is currently requested.
>  	targetsBatchID string                  // ID of the channel history targets batch being processed.
>  	targetsBatch   HistoryTargetsEvent     // channel history targets batch being processed.
> +	monitors       map[string]struct{}     // set of users we want to monitor (and keep even if disconnected).

Comment is a bit confusing at first, can you s/if/if they are/

Also, instead of a map, how about a "monitored" field in s.users? Since it's only useful for RPL_MONONLINE handling, where you need access to s.users anyway.

Re: [PATCH senpai v2] Add option to disable join/part/quit messages 2 days ago

From Hubert Hirtz to ~taiite/public-inbox

On 29/11/2021 15:43, delthas wrote:
>> Well I don't really know what to do with this.
> This is orthogonal to event-playback. Some people use IRC for technical 
> support rather than chatting with friends, and for them user event 
> traffic isn't really needed.

1/ senpai and its purposely lightweight UI is not the kind of client 
you'd use for technical support or as a chanop, rather one like irssi or 
weechat is better suited.

2/ this is the kind of setting you'd want to have per-channel, which is 
not something I would like to have to maintain.  Again, other clients do 
that perfectly, no need for senpai here.

Re: [PATCH senpai] config: remove debugging fmt.Println 2 days ago

From Hubert Hirtz to ~taiite/public-inbox

Pushed your four patches, thanks!

Re: [PATCH senpai v2] Add option to disable join/part/quit messages 3 days ago

From Hubert Hirtz to ~taiite/public-inbox

Well I don't really know what to do with this.

delthas wanted join/parts/... to be shown even in history, thus sent a 
patch[0] to add support for event-playback[1].  If people actually don't 
want join/parts/... then I can revert the patch?

[0] https://lists.sr.ht/~taiite/public-inbox/patches/26813
[1] https://ircv3.net/specs/extensions/chathistory

Re: [PATCH senpai v2] Finish registration when not using SASL 5 days ago

From Hubert Hirtz to ~taiite/public-inbox

Thanks, pushed!

By the way, --in-reply-to is not (well) supported by lists.sr.ht, vN+1 
patches render better as separate threads :)

Re: [PATCH senpai] Merge MODE messages 6 days ago

From Hubert Hirtz to ~taiite/public-inbox

Pushed

Re: [PATCH senpai] Merge MODE messages 6 days ago

From Hubert Hirtz to ~taiite/public-inbox

On 24/11/2021 18:03, delthas wrote:
> Also, fix an issue where mode strings only displayed the first
> parameter.
> ---
>   app.go         | 3 ++-
>   irc/session.go | 7 ++++---
>   2 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/app.go b/app.go
> index 00c31d2..f50f8bd 100644
> --- a/app.go
> +++ b/app.go
> @@ -1009,12 +1009,13 @@ func (app *App) formatEvent(ev irc.Event) ui.Line {
>   			Body:      ui.Styled(body, tcell.StyleDefault.Foreground(tcell.ColorGray)),