From Hubert Hirtz to ~taiite/public-inbox
Hi thanks for the patch. IIUC you want gaps to be one cell wide, is that right? The gaps have been set to 2 originally because highlight nicks have padding. This padding would need to take the gap width into account, and senpai hasn't the kind of UI that is made for narrow windows anyway. I don't think it makes sense to add all this code just for 2 cells.
From Hubert Hirtz to ~taiite/public-inbox
Thanks for the patch. It works well, just an edge case that needs to be handled: 1. type "/m #channel +b" 2. place cursor after "/m" 3. press tab You'll need to take the first word of "text" only, and append the rest of "text" to each completion.
From Hubert Hirtz to ~taiite/public-inbox
On 15/12/2021 03:53, Kalyan Sriram wrote: > Improve show buffer numbers on "/buffer" command. Checks completion > against list of commands to avoid ambigious "/b" matching ("BUFFER" v. > "BAN"). Matches uppercase and mixed case i.e. "/BU" or "/bU". I see, thanks for the patch. While I don't use neither buffer numbers nor /buffer myself, I expect typing "/b <number>" be the common practice, and this patch breaks it? What do you think?
From Hubert Hirtz to ~taiite/public-inbox
Thanks! pushed
From Hubert Hirtz to ~taiite/public-inbox
Long-form text and spell checking are out of scope of senpai for sure. I don't think spawning a full-fledged editor makes a lot of sense for IRC. However, patches are accepted/in progress for - keybindings, there are already a lot listed in "doc/senpai.1", they are mostly conventional and are implemented in other terminal software as well (neovim included), - grapheme cluster support, there has been some work on github[0], this would allow a single backspace/left/right press to navigate through whole graphemes/characters instead of rune per rune. Is that what you miss from your editor? By special symbols, do you mean IME? IIUC it is supported at the terminal level (e.g. foot, kitty and gnome-terminal have support), I
From Hubert Hirtz to ~taiite/public-inbox
Pushed, thanks!
From Hubert Hirtz to ~taiite/public-inbox
Thanks, pushed!
From Hubert Hirtz to ~taiite/public-inbox
Thanks, pushed! On 06/12/2021 12:49, Leon Henrik Plickat wrote: > --- > v1 -> v2: document keybinds in man page > app.go | 3 +++ > doc/senpai.1.scd | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git a/app.go b/app.go > index 2b0ba82..956c89e 100644 > --- a/app.go > +++ b/app.go > @@ -513,6 +513,7 @@ func (app *App) handleKeyEvent(ev *tcell.EventKey) {
From Hubert Hirtz to ~taiite/public-inbox
Thanks, looks good. Can you update the man page?
From Hubert Hirtz to ~taiite/public-inbox
Thanks for the patch :) Can you update doc/senpai.1.scd with the new keybindings?