~taiite

France

http://git.sr.ht/~taiite

~taiite/public-inbox

Last active a month ago
View more

Recent activity

[PATCH soju] Fix help message for BouncerServ's network update 7 days ago

From Hubert Hirtz to ~emersion/public-inbox

It was missing the network name as first argument.
---
 service.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/service.go b/service.go
index 78c67c4..76c683b 100644
--- a/service.go
+++ b/service.go
@@ -156,7 +156,7 @@ func init() {
					handle: handleServiceNetworkStatus,
				},
				"update": {
					usage:  "[-addr addr] [-name name] [-username username] [-pass pass] [-realname realname] [-nick nick] [-connect-command command]...",
[message trimmed]

Re: [PATCH gamja v2] Add error reporting on connect and main page 17 days ago

From Hubert Hirtz to ~emersion/public-inbox

Here I am shamelessly trying out reviewing patches via email. Not even
trying to see if anything is wrong with this one...

It seems you included more commits than you should have. If your patch
only has one commit, you can use:

    git send-email --annotate -v42 'HEAD^'

Also, indentation is mixed tabs/spaces here and there.

> ---
> 
> Apologies for the duplicate patch! I'm still working out the Git email workflow :)
> This one should fix all the things you pointed out. Please let me know if there's

[PATCH soju v2] Send compact channel name lists a month ago

From Hubert Hirtz to ~emersion/public-inbox

This commit resolves `sendNames`' TODO.
---
 bridge.go | 30 +++++++++++++++++++++++++++---
 irc.go    |  2 ++
 2 files changed, 29 insertions(+), 3 deletions(-)

diff --git a/bridge.go b/bridge.go
index c6080af..f1a7526 100644
--- a/bridge.go
@@ -2,6 +2,7 @@ package soju

import (
	"gopkg.in/irc.v3"
[message trimmed]

[PATCH soju] Send compact channel name lists a month ago

From Hubert Hirtz to ~emersion/public-inbox

This commit resolves `sendNames`' TODO.
---
 bridge.go | 30 +++++++++++++++++++++++++++---
 irc.go    |  2 ++
 2 files changed, 29 insertions(+), 3 deletions(-)

diff --git a/bridge.go b/bridge.go
index c6080af..1abf5b9 100644
--- a/bridge.go
@@ -2,6 +2,7 @@ package soju

import (
	"gopkg.in/irc.v3"
[message trimmed]

[PATCH soju] Don't save corrupted NickServ credentials a month ago

From Hubert Hirtz to ~emersion/public-inbox

soju saved most NickServ messages[0] as credentials because of a missing
`default` clause in the check of the NickServ command.

[0] messages that had at least a command and two other parameters
---
 downstream.go | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/downstream.go b/downstream.go
index 6ea160c..fdc6cc6 100644
--- a/downstream.go
+++ b/downstream.go
@@ -1557,6 +1557,8 @@ func parseNickServCredentials(text, nick string) (username, password string, ok
			username = nick
[message trimmed]

[PATCH gamja] irc: Strip lone backslashes from tag values a month ago

From Hubert Hirtz to ~emersion/public-inbox

According to the message-tags spec:

> If a lone \ exists at the end of an escaped value (with no escape
> character following it), then there SHOULD be no output character. For
> example, the escaped value test\ should unescape to test.

https://ircv3.net/specs/extensions/message-tags
---
 lib/irc.js | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/irc.js b/lib/irc.js
index 37bb4cb..6766a1b 100644
--- a/lib/irc.js
[message trimmed]

[PATCH soju v2] Send the full user mask in RPL_LOGGEDIN 2 months ago

From Hubert Hirtz to ~emersion/public-inbox

As per the spec at https://ircv3.net/specs/extensions/sasl-3.1

:server 900 <nick> <nick>!<ident>@<host> <account> :Now logged in
---
 downstream.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/downstream.go b/downstream.go
index d80ced5..6ea160c 100644
--- a/downstream.go
+++ b/downstream.go
@@ -416,7 +416,7 @@ func (dc *downstreamConn) handleMessageUnregistered(msg *irc.Message) error {
			dc.SendMessage(&irc.Message{
				Prefix:  dc.srv.prefix(),
[message trimmed]

[PATCH soju] Send the full user mask in RPL_LOGGEDIN 2 months ago

From Hubert Hirtz to ~emersion/public-inbox

As per the spec at https://ircv3.net/specs/extensions/sasl-3.1

:server 900 <nick> <nick>!<ident>@<host> <account> :Now logged in
---
 downstream.go | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/downstream.go b/downstream.go
index d80ced5..40683d3 100644
--- a/downstream.go
+++ b/downstream.go
@@ -413,10 +413,11 @@ func (dc *downstreamConn) handleMessageUnregistered(msg *irc.Message) error {
			return fmt.Errorf("SASL authentication failed: %v", err)
		} else if done {
[message trimmed]

Re: [PATCH soju] Support UNIX listeners 2 months ago

From Hubert Hirtz to ~emersion/public-inbox

> I'd prefer to use a URI scheme for consistency with upstream URLs:
> 
> - ircs://<host>:<port>
> - irc+insecure://<host>:<port>
> - unix://<path>
> 
> If the scheme isn't specified, assume "ircs". If the port isn't specified,
> deduce it from the scheme.

I disagree:

- it would be redundant, how should soju behave if "listen" is set to 
"ircs://localhost:6667" but "tls" is unset?
- thus "ircs" wouldn't be the default scheme, since TLS is enabled with

[PATCH soju] Support UNIX listeners 2 months ago

From Hubert Hirtz to ~emersion/public-inbox

Since soju isn't shutting down gracefully, UNIX sockets aren't closed
and thus need to be removed manually before running soju again. For now.
---
 cmd/soju/main.go | 11 +++++++++--
 doc/soju.1.scd   |  9 +++++----
 2 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/cmd/soju/main.go b/cmd/soju/main.go
index 5f80fb4..647530d 100644
--- a/cmd/soju/main.go
+++ b/cmd/soju/main.go
@@ -5,6 +5,7 @@ import (
	"flag"
	"log"
[message trimmed]