~taiite/public-inbox

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
3 2

[PATCH senpai] Send CAP END before completing registration

Details
Message ID
<20211121120938.303696-1-mooff@awful.cooking>
DKIM signature
missing
Download raw message
Patch: +1 -0
From: mooff <mooff@cyberspace.baby>

Required by spec, InspIRCd
---
 irc/session.go | 1 +
 1 file changed, 1 insertion(+)

diff --git a/irc/session.go b/irc/session.go
index 8467f2c..31b2d0e 100644
--- a/irc/session.go
+++ b/irc/session.go
@@ -164,6 +164,7 @@ func NewSession(out chan<- Message, params SessionParams) *Session {
	for capability := range SupportedCapabilities {
		s.out <- NewMessage("CAP", "REQ", capability)
	}
	s.out <- NewMessage("CAP", "END")
	s.out <- NewMessage("NICK", s.nick)
	s.out <- NewMessage("USER", s.user, "0", "*", s.real)

-- 
2.30.2
Details
Message ID
<d1e5cb74-fb95-442e-90c8-046fa1db5c41@hirtz.pm>
In-Reply-To
<20211121120938.303696-1-mooff@awful.cooking> (view parent)
DKIM signature
pass
Download raw message
Thanks for the patch!  However, CAP END must come after the SASL 
authentication, if any.  Wrapping this line in a if block should be 
enough.  See irc.Session.auth!

[PATCH senpai v2] Finish registration when not using SASL

Details
Message ID
<20211125005157.71757-1-mooff@awful.cooking>
In-Reply-To
<20211121120938.303696-1-mooff@awful.cooking> (view parent)
DKIM signature
missing
Download raw message
Patch: +4 -0
From: mooff <mooff@cyberspace.baby>

We wait until after AUTHENTICATE to send CAP END like a good client,
but it needs to be sent when SASL isn't used, too.
---
 irc/session.go | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/irc/session.go b/irc/session.go
index ea852d7..2b9680a 100644
--- a/irc/session.go
+++ b/irc/session.go
@@ -168,6 +168,10 @@ func NewSession(out chan<- Message, params SessionParams) *Session {
	s.out <- NewMessage("NICK", s.nick)
	s.out <- NewMessage("USER", s.user, "0", "*", s.real)

	if s.auth == nil {
		s.endRegistration()
	}

	return s
}

-- 
2.30.2

Re: [PATCH senpai v2] Finish registration when not using SASL

Details
Message ID
<51d27d64-aef3-c2f8-dd13-f6263628bd97@hirtz.pm>
In-Reply-To
<20211125005157.71757-1-mooff@awful.cooking> (view parent)
DKIM signature
pass
Download raw message
Thanks, pushed!

By the way, --in-reply-to is not (well) supported by lists.sr.ht, vN+1 
patches render better as separate threads :)
Reply to thread Export thread (mbox)