senpai: Use RPL_SASLSUCCESS to end registration v1 APPLIED

Simon Ser: 1
 Use RPL_SASLSUCCESS to end registration

 1 files changed, 1 insertions(+), 2 deletions(-)

[PATCH senpai] Use RPL_SASLSUCCESS to end registration Export this patch

See https://github.com/ircv3/ircv3-specifications/pull/476
---
 irc/session.go | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/irc/session.go b/irc/session.go
index 2b9680ad81e4..b6d5873ca79a 100644
--- a/irc/session.go
+++ b/irc/session.go
@@ -512,7 +512,7 @@ func (s *Session) handleUnregistered(msg Message) (Event, error) {
 
 		s.out <- NewMessage("NICK", nick+"_")
 	case rplSaslsuccess:
-		// do nothing
+		s.endRegistration()
 	default:
 		return s.handleRegistered(msg)
 	}
@@ -572,7 +572,6 @@ func (s *Session) handleMessageRegistered(msg Message, playback bool) (Event, er
 			return nil, err
 		}
 
-		s.endRegistration()
 		prefix := ParsePrefix(nuh)
 		s.user = prefix.User
 		s.host = prefix.Host

base-commit: c5a148573da8542178413dadac10d3df13a596cf
-- 
2.34.1

Hubert Hirtz <hubert@hirtz.pm>

5 months ago

Pushed, thanks!