senpai: ui: use reverse colors for current buffer instead of underline v1 PROPOSED

Simon Ser: 1
 ui: use reverse colors for current buffer instead of underline

 1 files changed, 3 insertions(+), 5 deletions(-)

[PATCH senpai] ui: use reverse colors for current buffer instead of underline Export this patch

I personally find this esthetically more pleasing.
---
 ui/buffers.go | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/ui/buffers.go b/ui/buffers.go
index aa5e9fefe9ce..1ccb921a2a3f 100644
--- a/ui/buffers.go
+++ b/ui/buffers.go
@@ -469,10 +469,8 @@ func (bs *BufferList) DrawVerticalBufferList(screen tcell.Screen, x0, y0, width,
 		st := tcell.StyleDefault
 		if b.unread {
 			st = st.Bold(true)
-		} else if bi == bs.current {
-			st = st.Underline(true)
 		}
-		if bi == bs.clicked {
+		if bi == bs.current || bi == bs.clicked {
 			st = st.Reverse(true)
 		}
 		if bs.showBufferNumbers {
@@ -486,7 +484,7 @@ func (bs *BufferList) DrawVerticalBufferList(screen tcell.Screen, x0, y0, width,
 		if b.title == "" {
 			title = b.netName
 		} else {
-			if bi == bs.clicked {
+			if bi == bs.current || bi == bs.clicked {
 				screen.SetContent(x, y, ' ', nil, tcell.StyleDefault.Reverse(true))
 				screen.SetContent(x+1, y, ' ', nil, tcell.StyleDefault.Reverse(true))
 			}
@@ -496,7 +494,7 @@ func (bs *BufferList) DrawVerticalBufferList(screen tcell.Screen, x0, y0, width,
 		title = truncate(title, width-(x-x0), "\u2026")
 		printString(screen, &x, y, Styled(title, st))
 
-		if bi == bs.clicked {
+		if bi == bs.current || bi == bs.clicked {
 			st := tcell.StyleDefault.Reverse(true)
 			for ; x < x0+width; x++ {
 				screen.SetContent(x, y, ' ', nil, st)

base-commit: 65718d37abc15e727c20b9b031d32b953b258d2a
-- 
2.34.1

Hubert Hirtz <hubert@hirtz.pm>

2 years ago

Pushed, thanks!