Edison Ibáñez <arkhan@riseup.net> writes:

> I have For several days notmuch-transient gives the following error:

Thanks for the report.

I forgot to update `notmuch-search-transient--setup' after a breaking
change in transient.  If fixed that now.

     Jonas

Aleksandr Vityazev <avityazev@posteo.org> writes:

> Hi,
>
> On 2022-11-11, 03:02 +0100, Jonas Bernoulli <jonas@bernoul.li> wrote:
>
>> A package named "test" exists.  The file "test.el" in this repository
>> conflicts with that package.  If someone uses both the "test" and "srht"
>> packages, this could get confusing.
>>
>> Please consider renaming "test.el" to "srht-test.el".  Also note that
>> test files should normally not provide a feature, since features are
>> intended for libraries that are loaded by the user using `require'.
>

Hello,

A package named "test" exists.  The file "test.el" in this repository
conflicts with that package.  If someone uses both the "test" and "srht"
packages, this could get confusing.

Please consider renaming "test.el" to "srht-test.el".  Also note that
test files should normally not provide a feature, since features are
intended for libraries that are loaded by the user using `require'.

     Cheers,
     Jonas

Philip Kaludercic <philipk@posteo.net> writes:

> Hi Jonas,
>
> if you could find some time, could you check out this issue on the
> compat issue tracker: https://todo.sr.ht/~pkal/compat/4.  I believe the
> last message ~temporal might be related to these patches.

I am taking a month or two off and I don't think it would be a good
idea for me to already make an exceptions only a few days in.  Sorry.

     Jonas

Philip Kaludercic <philipk@posteo.net> writes:

> I have pushed a commit implementing this behaviour, could you check if
> it fixes the issue?

`compat--entwine-version' is also just "XY", so wouldn't we have to
append ".1" to that too?

Philip Kaludercic <philipk@posteo.net> writes:
> Just to be sure: The issue we are dealing with here is that entwine
> binds `byte-compile-current-file', and you are saying that the macro
> generator functions assume the version is communicated using these
> files, right?

Yes.

> What I don't understand is how the
>
> --8<---------------cut here---------------start------------->8---
> (or (bound-and-true-p byte-compile-current-file)
>     load-file-name
>     (buffer-file-name))

Jonas Bernoulli <jonas@bernoul.li> writes:

> `compat-entwine' is called in two and only three distinct situations.

Please fix s/two/three/ before merging. :P

Of course also feel free to remove the comments, trim down the commit
message, or make other changes.

`compat-entwine' is called in two and only three distinct situations.

1. When "compat.el" is being loaded without having been compiled
   before.  This can happen while a third-party library is being
   compiled, which requires `compat'.

2. When "compat.el" is being evaluated, such as when using
   `eval-buffer'.

3. When "compat.el" is being compiled.

In all cases we need to detect where "compat.el" is located, because
that also tells us where the "compat-XY.el" libraries are located and
`compat-entwine' needs to read the contents of those files.  To detect
[message trimmed]

---
 compat-macs.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/compat-macs.el b/compat-macs.el
index 4f2d44e..fec167a 100644
--- a/compat-macs.el
+++ b/compat-macs.el
@@ -166,7 +166,7 @@ (defun compat--generate-verbose (name def-fn install-fn check-fn attr type)
                          ((string-match
                            "compat-\\([[:digit:]]+\\)\\.\\(?:elc?\\)\\'"
                            file)
-                          (match-string 1 file))
+                          (concat (match-string 1 file) ".1"))
[message trimmed]

"If i had more time i would have written a shorter commit message."

Jonas Bernoulli (2):
  Add fix from faabc69ba to compat--generate-verbose too
  Fix using compat libraries uncompiled

 compat-macs.el | 54 ++++++++++++++++++++++++++------------------------
 compat.el      | 30 ++++++++++++++++++----------
 2 files changed, 48 insertions(+), 36 deletions(-)

-- 
2.35.1