notmuch-transient: Replace hardcoded colors with new faces v1 APPLIED

Protesilaos Stavrou: 1
 Replace hardcoded colors with new faces

 1 files changed, 14 insertions(+), 3 deletions(-)

I've moved the comment into the commit message and added a custom group.

Export patchset (mbox)
How do I use this?

Copy & paste the following snippet into your terminal to import this patchset into git:

curl -s https://lists.sr.ht/~tarsius/public-inbox/patches/31251/mbox | git am -3
Learn more about email & git

[PATCH notmuch-transient] Replace hardcoded colors with new faces Export this patch

This improves the presentation for all themes and gives power to the
user to change the applicable colors (or face attributes in general).
 notmuch-transient.el | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/notmuch-transient.el b/notmuch-transient.el
index 2cc8ee5..3dd98f0 100644
--- a/notmuch-transient.el
+++ b/notmuch-transient.el
@@ -43,6 +43,17 @@ (defvar notmuch-transient-add-bindings t
(defvar notmuch-transient-prefix (kbd "C-d")
  "The prefix key used for various transient commands.")

;; We inherit from `success' and `error' because they are always
;; available and should be supported by all themes.  The semantics of
;; those words do not apply in our case.
(defface notmuch-transient-add-tag
  '((t :inherit success))
  "Face for tags to be added to the current list.")

(defface notmuch-transient-remove-tag
  '((t :inherit error))
  "Face for tags to be removed from the current list.")

;;; Hello

;;;###autoload (autoload 'notmuch-hello-mode-transient "notmuch-transient" nil t)
@@ -321,9 +332,9 @@ (cl-defmethod transient-format-value ((obj notmuch-transient-tag-infix))
                            (= op ?+))
                        change 'face
                        (list :foreground (if (= op ?+)
                                              "dark green"
                                            "dark red")))
                        (if (= op ?+)
               (notmuch-transient-tag-infix--get-changes obj)
               " ")))

Protesilaos Stavrou
Hello Jonas!

I understand this package is still in its early days.  The patch is just
a suggestion: I thought it was easier to do it this way than start a
discussion.  Feel welcome to ignore it or otherwise adapt it to your

All the best,