~technomancy

WA, USA

https://technomancy.us

tryin' to catch the last train out of Omelas

~technomancy/fennel

Last active 6 days ago
View more

Recent activity

Re: [PATCH] Fix typos in code comments a month ago

From Phil Hagelberg to ~technomancy/fennel

Looks good; thanks! Applied and pushed.

-Phil

Re: [PATCH] Fix inconsistent capitalization in 'fennel --help' a month ago

From Phil Hagelberg to ~technomancy/fennel

Rudolf Adamkovič <rudolf@adamkovic.org> writes:

> The help message mixes "REPL" and "repl", "Fennel" and "fennel", etc.  This
> patch unifies both.  Also, Lisp is capitalized, as we refer to the family of
> languages, not the speech impediment.

Sure; applied and pushed.

thanks,
Phil

Re: [PATCH] Show evaluation results in the echo area a month ago

From Phil Hagelberg to ~technomancy/fennel

Rudolf Adamkovič <rudolf@adamkovic.org> writes:

> All right, see the attached patch.
>
> Now in full color! :)

Cool; thanks, I've applied and pushed.

-Phil

Re: [PATCH] Show evaluation results in the echo area a month ago

From Phil Hagelberg to ~technomancy/fennel

Overall looks good, but this tests only passes if you already have a
repl open, so it fails when running the tests in batch mode.

> +(ert-deftest fennel-mode-eval-test ()
> +  (with-temp-buffer
> +    (insert "(+ 5 5)")
> +    (fennel-mode)
> +    (message nil)
> +    (fennel-eval-last-sexp)
> +    (should
> +     (let ((deadline (+ (string-to-number (emacs-uptime "%s")) 5)))
> +       (named-let try-again ()
> +         (cond ((equal "10" (current-message)) t)
> +               ((> (string-to-number (emacs-uptime "%s")) deadline) nil)

Re: [PATCH] Treat top-level forms as outline headings a month ago

From Phil Hagelberg to ~technomancy/fennel

Phil Hagelberg <phil@hagelb.org> writes:

> Unfortunately there seems to be an issue with the tests when I run them
> here, both on 28.2 and the latest build from git.

Aha, OK; this was an issue with the way I was running the tests. It
looks like the instructions in the readme aren't correct. I haven't
really used ert before.

I'll add a makefile to ensure this can be avoided in the future; in the
mean time I'll go ahead and apply the patch.

-Phil

Re: [PATCH] Treat top-level forms as outline headings a month ago

From Phil Hagelberg to ~technomancy/fennel

Rudolf Adamkovič <rudolf@adamkovic.org> writes:

> Fennel mode users can use the Outline minor mode to cycle between seeing
>
>   (1) all content and
>   (2) section titles as per the ';;;;' comments.
>
> With this patch, they can cycle further to see
>
>   (3) section titles *along with* the first line of
>       the top-level forms within each section.
>
> The change is inspired by the built-in Emacs Lisp mode.

Re: Last value's computation in multiple return is function a month ago

From Phil Hagelberg to ~technomancy/fennel

"Jason Shipman" <jasonpshipman@gmail.com> writes:

> When individual values of a multiple return have their own bindings,
> I've observed that the resulting Lua has the last return value's
> computation wrapped in a function rather than a do block.
>
> Is this due to a nuance/operational detail of Lua?

Yes, unfortunately we have to do some compilation magic to work around
the fact that Lua has statements and multiple values. We call it IIFE, or
immediately-invoked function expressions. In an expression-only
language, there are certain constructs that as you've observed can't be
compiled directly to statements without some kind of wrapper to protect it.

[PATCH] Avoid include warnings when compiling. a month ago

From Phil Hagelberg to ~xerool/fennel-ls

Also update the readme regarding Emacs; version 30 doesn't need any config.
---
 Makefile  | 3 ++-
 README.md | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index b6c5430..c3c54da 100644
--- a/Makefile
+++ b/Makefile
@@ -11,8 +11,9 @@ PREFIX ?= /usr/local
BINDIR ?= $(PREFIX)/bin

OPTS=--add-package-path "./src/?.lua" --add-fennel-path "./src/?.fnl"
[message trimmed]

Re: [fennel/patches/.build.yml] build failed a month ago

From Phil Hagelberg to ~technomancy/fennel

Thanks for catching this; applied and pushed.

-Phil

Re: [PATCH fnlfmt] Prevent unnecessary writes with --fix a month ago

From Phil Hagelberg to ~technomancy/fennel

Oliver Vartiainen <oliver@rakkine.fi> writes:

> in order to allow tooling around fnlfmt to work right

Thanks!

I realized this same logic would be useful for the --check
implementation, not just --fix, so I've added it to that as well.

I've applied and pushed.

-Phil