sarna <sarna@chaszcze.org> writes:

> Hope this works :)

Looks good; thanks! I always get curl and wget mixed up for this, haha.

-Phil

Thanks; I've pushed this out and also the no-arguments one.

-Phil

"Michele Campeotto" <micampe@micampe.it> writes:

> I thought about it, but I think it should also have syntax highlighting
> first. Helix uses tree-sitter so maybe we can reuse the nvim queries, I
> can give it a try but I've never looked into tree-sitter much.

Ah, well I was thinking about it like it would be a 1-line change. I
mean if you want to go further with it that's up to you. =)

> Do you think we should wait for a final decision on the fnlm macro path
> change and add that too?

There hasn't really been any discussion about the issue I opened, so
I'll take that to mean there's no objections. I think it's a good idea,

Michele Campeotto <micampe@micampe.it> writes:

> +Make sure `fennel_ls` is available in your `$PATH` and then add this to your
> +`~/.config/helix/languages.toml` file:

Thanks! I've applied all 3 in this series.

Is it possible to submit a patch to Helix so it can auto-detect this the
way that Emacs does? Would be nice if future versions could make manual
configuration unnecessary.

-Phil

Michele Campeotto <micampe@micampe.it> writes:

> The unnecessary tset lint was assuming a single key, but it was
> triggering for calls with multiple nested keys, causing the quickfix
> action to drop all elements after the fourth argument, which was assumed
> to be the value.

Great catch; thanks! Glad to see the thorough tests.

-Phil

Michele Campeotto <micampe@micampe.it> writes:


> @@ -222,9 +221,8 @@ find the definition `10`, but if `opts.stop-early?` is set, it would find
>  (λ _past? [?ast byte]
>    ;; check if a byte is past an ast object
>    (and (= (type ?ast) :table)
> -       (get-ast-info ?ast :bytestart)
> -       (< byte (get-ast-info ?ast :bytestart))
> -       false))
> +       (get-ast-info ?ast :byteend)
> +       (< (get-ast-info ?ast :byteend) byte)))

This is not a problem, but I'm curious why you edited this function that

Hello!

Today (in a few minutes) we are having the monthly Fennel group online.

If you're free, come on over to join and talk about whatever Fennel
topics are on your mind! Or show up late; we usually are on the call for
at least two hours.

We are trying out a self-hosted call today:

https://live.technomancy.us/fennel

That's a different site from the one we've used in the past, so I just
wanted to give a heads up about that.

Michele Campeotto <micampe@micampe.it> writes:

> The clean target deletes the build directory, but it's only created by
> the docs generation target, which is not normally invoked by a build.

Yep, good catch. Thanks.

-Phil

Michele Campeotto <micampe@micampe.it> writes:

> These strings will be displayed in a menu for the user to select.
>
> The error codes, in addition to not being human readable sentences,
> describe the issue being reported, not the solution that will be
> applied.
>
> The code action response only includes the human readable string, so the
> tests need to check for that. I considered adding a custom field but
> decided against going out of spec.

Thanks; looks great!

Yuxuan Shui <yshuiv7@gmail.com> writes:

> I agree, if it is not maintained then I think including it in the repo will only
> give people the wrong impression.

I've removed the packaging for nix as well as the unmaintained scripts
for Luarocks.

It would be great if we could find someone who knows and uses luarocks
to handle packaging it in a downstream repository. Unfortunately the
permission system in luarocks.org is not very flexible and it requires
manual intervention from the creator of luarocks to change the owner,
which we did with Fennel itself: