Nice idea; thanks! Applied and pushed.

-Phil

I'm proud to announce, with the help of many wonderful contributors, the
release of Fennel 0.3.0!

This release introduces docstrings as well as several new features to
the macro system and some breaking changes; the most significant being
the new unquote syntax and the requirement of auto-gensym for
identifiers in backtick.

* Fix a bug where errors would show incorrect line numbers
* Add support for docstrings and `doc` for displaying them in repl
* Support `:detect-cycles? false` in fennelview to turn off "#<table 1>" output
* **Disallow** non-gensym identifiers in backtick/macros
* Support `x#` syntax for auto-gensym inside backtick
* Fix a bug in `lambda` arity checks when using destructuring

Thanks; just pushed this out.

-Phil

Benaiah Mischenko <benaiah@mischenko.com> writes:

> ---
>  fennel.lua | 4 +++-
>  test.lua   | 3 +++
>  2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/fennel.lua b/fennel.lua
> index c5e451b..1f3bbe7 100644
> --- a/fennel.lua

Benaiah Mischenko <benaiah@mischenko.com> writes:

> Phil Hagelberg <phil@hagelb.org> writes:
>
>> This one's actually causing some test failures; can you take another look?
>
> Whoops, should have remembered to run the tests before I submitted the
> patch. It was replacing every "if true then" to "else" as well, which
> obviously doesn't work in lua. Thanks for catching this - submitting a
> fixed and rebased patch now.

No worries; thanks. Pushed this as well as the hashfn patch.

-Phil

Benaiah Mischenko <benaiah@mischenko.com> writes:

> -        local condLine = fstr:format(tostring(branch.cond))
> +        local cond = tostring(branch.cond)
> +        local condLine = cond == "true" and "else" or fstr:format(cond)

This one's actually causing some test failures; can you take another look?

thanks,
Phil

Thanks; applied! Nice catch.

-Phil

Benaiah Mischenko <benaiah@mischenko.com> writes:

> I've attached the patch instead of using git send-email; maybe it will
> thread better?

Thanks; looks great. I've applied and pushed it out.

-Phil

Looks like git send-email screwed up the threading on this AGAIN, so
I'll just continue the conversation here with patches in attachments instead.

Benaiah Mischenko <benaiah@mischenko.com> writes:

> Phil Hagelberg <phil@hagelb.org> writes:
>
>> I just realized that the list in issymbolchar is a *disallowed* list,
>> not a list of allowed chars. So ~ is already intended to be blocked, but
>> it's not blocked consistently, since ~= is allowed to be used.
>
> o.O this definitely does not seem like intended behavior.

The first patch contains a small fix for this; disallowed symbols are

This allows us to retain backwards compatibility but still reserves ~
for future use by the compiler.
---
 changelog.md | 1 -
 fennel.lua   | 7 ++++++-
 test.lua     | 1 +
 3 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/changelog.md b/changelog.md
index e34b03e..0e363c9 100644
--- a/changelog.md
+++ b/changelog.md
@@ -17,7 +17,6 @@
 * Alias `#` special with `length`
[message trimmed]

Previously we would allow symbols with illegal characters as long as
the illegal character was the first one.
---
 fennel.lua | 4 +++-
 test.lua   | 2 ++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/fennel.lua b/fennel.lua
index 7792184..00a970b 100644
--- a/fennel.lua
+++ b/fennel.lua
@@ -361,7 +361,7 @@ local function parser(getbyte, filename)
                     end
                 end
[message trimmed]