~technomancy/fennel

2 2

Re: Fwd: [PATCH] migrating repl to a web worker

Details
Message ID
<87y2lz61p4.fsf@hagelb.org>
DKIM signature
missing
Download raw message
> This patch suggests using a Web Worker for the web REPL. I tried to
> modify as little code as possible.

Hey sorry for the delay on this; I'm not too savvy about web workers and
stuff but I don't know if we'll get any other review so I just went
ahead and applied it; we'll see how it goes.

Thanks!

-Phil

Re: Fwd: [PATCH] migrating repl to a web worker

Details
Message ID
<87wo1j61hj.fsf@hagelb.org>
In-Reply-To
<87y2lz61p4.fsf@hagelb.org> (view parent)
DKIM signature
missing
Download raw message
Phil Hagelberg <phil@hagelb.org> writes:

>> This patch suggests using a Web Worker for the web REPL. I tried to
>> modify as little code as possible.
>
> Hey sorry for the delay on this; I'm not too savvy about web workers and
> stuff but I don't know if we'll get any other review so I just went
> ahead and applied it; we'll see how it goes.

Shoot; actually I spoke too soon--this causes the repl to break in
Luakit, so I had to revert it. I don't see any errors or anything; it
just shows "Loading..." and climbs up to 99% but never gets beyond that.

Not sure what's going on.

-Phil

Re: Fwd: [PATCH] migrating repl to a web worker

Details
Message ID
<9020187a-594c-517b-a5c5-e63699407f49@protonmail.com>
In-Reply-To
<87wo1j61hj.fsf@hagelb.org> (view parent)
DKIM signature
pass
Download raw message
Phil Hagelberg <phil@hagelb.org> writes:

 > Shoot; actually I spoke too soon--this causes the repl to break in
 > Luakit, so I had to revert it. I don't see any errors or anything; it
 > just shows "Loading..." and climbs up to 99% but never gets beyond that.

Oh, sad to hear that. Thank you for trying to apply the patch and report
the problem.

I realized that I hadn't done any tests on luakit, so, my bad! Sorry
about that. I will check what is going on and try to fix it.

I will also test it on the nyxt browser besides luakit. Suggestions
about other browsers that we should use in the tests?
Export thread (mbox)