~tenacity/tenacity-dev

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
4 2

[PATCH] cmake: Add install target for libnyquist

Haelwenn (lanodan) Monnier <contact@hacktivis.me>
Details
Message ID
<20210919100254.7498-1-contact@hacktivis.me>
DKIM signature
pass
Download raw message
Patch: +7 -1
Signed-off-by: Haelwenn (lanodan) Monnier <contact@hacktivis.me>
---
 BUILDING.md                       | 2 +-
 lib-src/libnyquist/CMakeLists.txt | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/BUILDING.md b/BUILDING.md
index d63f84572..807c2b11c 100644
--- a/BUILDING.md
+++ b/BUILDING.md
@@ -341,4 +341,4 @@ has outdated libraries that do not build with Tenacity.
  * **LV2** (ON|OFF): LV2 plugin hosting support. Requires LV2, lilv, and
    suil libraries.
  * **VST2** (ON|OFF): VST2 plugin hosting support. Requires GTK with X11
    support on non-Apple/Windows.
    support on non-Apple/non-Windows.
diff --git a/lib-src/libnyquist/CMakeLists.txt b/lib-src/libnyquist/CMakeLists.txt
index 45993c7d3..d4d16c393 100644
--- a/lib-src/libnyquist/CMakeLists.txt
+++ b/lib-src/libnyquist/CMakeLists.txt
@@ -290,3 +290,9 @@ target_compile_options(libnyquist
   PRIVATE
      $<$<PLATFORM_ID:Darwin>:-fno-common>
)

install(
   TARGETS libnyquist
   LIBRARY
   DESTINATION "${_LIBDIR}"
)
-- 
2.32.0
Haelwenn (lanodan) Monnier <contact@hacktivis.me>
Details
Message ID
<YUcLxPkiMrFYe7ud@cloudsdale.the-delta.net.eu.org>
In-Reply-To
<20210919100254.7498-1-contact@hacktivis.me> (view parent)
DKIM signature
pass
Download raw message
[2021-09-19 12:02:54+0200] Haelwenn (lanodan) Monnier:
>    * **VST2** (ON|OFF): VST2 plugin hosting support. Requires GTK with X11
> -    support on non-Apple/Windows.
> +    support on non-Apple/non-Windows.

Erf sorry, I should have reviewed my patch properly before sending it, feel free to
edit out this part, can send another version after a review.
Details
Message ID
<CEDS418GIZU4.2O5KCOMET529M@neophyte>
In-Reply-To
<20210919100254.7498-1-contact@hacktivis.me> (view parent)
DKIM signature
pass
Download raw message
Could you re-send the patch as [PATCH tenacity], so the CI kicks in?
Thanks!

[PATCH tenacity v2] cmake: Add install target for libnyquist

Haelwenn (lanodan) Monnier <contact@hacktivis.me>
Details
Message ID
<20210919101215.10817-1-contact@hacktivis.me>
In-Reply-To
<CEDS418GIZU4.2O5KCOMET529M@neophyte> (view parent)
DKIM signature
pass
Download raw message
Patch: +6 -0
Signed-off-by: Haelwenn (lanodan) Monnier <contact@hacktivis.me>
---
 lib-src/libnyquist/CMakeLists.txt | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/lib-src/libnyquist/CMakeLists.txt b/lib-src/libnyquist/CMakeLists.txt
index 45993c7d3..d4d16c393 100644
--- a/lib-src/libnyquist/CMakeLists.txt
+++ b/lib-src/libnyquist/CMakeLists.txt
@@ -290,3 +290,9 @@ target_compile_options(libnyquist
   PRIVATE
      $<$<PLATFORM_ID:Darwin>:-fno-common>
)

install(
   TARGETS libnyquist
   LIBRARY
   DESTINATION "${_LIBDIR}"
)
-- 
2.32.0

Re: [PATCH tenacity v2] cmake: Add install target for libnyquist

Details
Message ID
<CEDS5M3FWMB1.20TT57VO4L4UF@neophyte>
In-Reply-To
<20210919101215.10817-1-contact@hacktivis.me> (view parent)
DKIM signature
pass
Download raw message
Oh, sourcehut doesn't detect patches sent as replies.
Please send a new email -- keeping it as v2 is fine.
Reply to thread Export thread (mbox)