tenacityaudio.org: New hero section and nav v1 REJECTED

~songtech-0912: 1
 Removed legacy conflicting hex codes for working dark theme

 1 files changed, 3 insertions(+), 3 deletions(-)

First, we would preferably not do cosmetic changes without overhauling
the content first.

We would also like you to squash/fixup your three commits into one and
send them as a v2. That is how it works here (Sending multiple
commits is generally frowned upon due to sending multiple e-mails +
artificially bloating the history.)

tenacityaudio.org/patches/.build.yml: FAILED in 13s

[New hero section and nav][0] from [~songtech-0912][1]

[0]: https://lists.sr.ht/~tenacity/tenacity-dev/patches/23832
[1]: mailto:dixinlily@hotmail.com

✗ #544297 FAILED tenacityaudio.org/patches/.build.yml https://builds.sr.ht/~tenacity/job/544297

This commit doesn't seem to be up-to-date either: most of the problems
have already been fixed upstream.

I think what happened is that you only sent your last in a series of
commits. Please send any meaningful change as one commit, instead of
three.

Ok, got it. I’ll squash the commits, and I’ll keep in mind the advice for the future.
(I am very inexperienced with the git working-by-email method, so forgive me
for this initial bad patch)

Regarding the cosmetic changes, would it perhaps be 
better for me to finish a design mock-up and send it to you all, and if 
approved, then work on the code? I think the design changes I made may 
need some further polishing and self-criticism.
I would like to know your opinions on this.

[PATCH tenacityaudio.org 1/1] Removed legacy conflicting hex codes for working dark theme Export this patch

From: Jacky Song <dixinlily@hotmail.com>

Signed-off-by: Jacky Song <dixinlily@hotmail.com>
---
 style.css | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/style.css b/style.css
index 9965ead..662176a 100644
--- a/style.css
+++ b/style.css
@@ -1,5 +1,4 @@
 html {
-    background-color: #fffdf8;
     height: 100vh;
     margin: 0;
     padding: 0;
@@ -8,7 +7,7 @@ html {
 
 body {
     margin: 2rem auto;
-    color: #4d4b46;
+    color: rgb(77,75,70);
     font-family: sans-serif;
     font-size: 16px;
     line-height: 1.5;
@@ -104,12 +103,13 @@ a:hover {
     header a {
         font-size: 12px;
     }
+}
 
 /* Dark mode */
 @media (prefers-color-scheme: dark) {
 
   html {
-    background-color: rgb(0 6 26);
+    background-color: rgb(17 17 17);
   }
 
   body {
-- 
2.30.2

Semisol <hi@semisol.dev>

3 years ago

First, we would preferably not do cosmetic changes without overhauling
the content first.

We would also like you to squash/fixup your three commits into one and
send them as a v2. That is how it works here (Sending multiple
commits is generally frowned upon due to sending multiple e-mails +
artificially bloating the history.)

builds.sr.ht <builds@sr.ht>

3 years ago

tenacityaudio.org/patches/.build.yml: FAILED in 13s

[New hero section and nav][0] from [~songtech-0912][1]

[0]: https://lists.sr.ht/~tenacity/tenacity-dev/patches/23832
[1]: mailto:dixinlily@hotmail.com

✗ #544297 FAILED tenacityaudio.org/patches/.build.yml https://builds.sr.ht/~tenacity/job/544297

Sol Fisher Romanoff <sol@solfisher.com>

3 years ago

This commit doesn't seem to be up-to-date either: most of the problems
have already been fixed upstream.

I think what happened is that you only sent your last in a series of
commits. Please send any meaningful change as one commit, instead of
three.