~tkoskine

Finland

http://iki.fi/tkoskine

Recent activity

Re: [PATCH v2] maildir: Provide nicer error message on invalid url 17 days ago

From Tero Koskinen to ~sircmpwn/aerc

Hi,

On Sat, 25 Jul 2020 08:23:16 +0200
Reto <reto@labrat.space> wrote:

> Hi,
> Thanks for the update
> 
> On Fri, Jul 24, 2020 at 10:38:50PM +0300, Tero Koskinen wrote:
> > +	f, err := os.Open(dir)
> > +	if err != nil {
> > +		return nil, err
> > +	}
> > +	s, _ := f.Stat()

[PATCH v3] maildir: Provide nicer error message on invalid url 17 days ago

From Tero Koskinen to ~sircmpwn/aerc

If accounts.conf contains an invalid maildir url, return a nice
error instead of panicking.

Log a couple of different error cases to provide extra
information about the error to the user.
---
 worker/maildir/container.go | 21 ++++++++++++++++++---
 worker/maildir/worker.go    | 17 ++++++++++++++++-
 2 files changed, 34 insertions(+), 4 deletions(-)

diff --git a/worker/maildir/container.go b/worker/maildir/container.go
index cd9a447..14815c9 100644
--- a/worker/maildir/container.go
+++ b/worker/maildir/container.go
[message trimmed]

Re: [PATCH] maildir: Provide nicer error message on invalid url 17 days ago

From Tero Koskinen to ~sircmpwn/aerc

Hi,

On Fri, 24 Jul 2020 09:48:35 +0200
Reto <reto@labrat.space> wrote:

> On Thu, Jul 23, 2020 at 09:00:02PM +0300, Tero Koskinen wrote:
> > I though about this, but ended up to my current solution because:
> > ...
> 
> Fair enough.
> Let's do it your way, but I'd still remove the check if it's a permission error if
> all you do is add more text to the log...

I sent the v2 version of the patch. It should contain the typo fix, have the extra

[PATCH v2] maildir: Provide nicer error message on invalid url 17 days ago

From Tero Koskinen to ~sircmpwn/aerc

If accounts.conf contains an invalid maildir url, return a nice
error instead of panicking.

Log a couple of different error cases to provide extra
information about the error to the user.
---
 worker/maildir/container.go | 18 +++++++++++++++---
 worker/maildir/worker.go    | 17 ++++++++++++++++-
 2 files changed, 31 insertions(+), 4 deletions(-)

diff --git a/worker/maildir/container.go b/worker/maildir/container.go
index cd9a447..fd46fd8 100644
--- a/worker/maildir/container.go
+++ b/worker/maildir/container.go
[message trimmed]

Re: [PATCH] maildir: Provide nicer error message on invalid url 18 days ago

From Tero Koskinen to ~sircmpwn/aerc

Hi,

Thanks for comments.

On Wed, 22 Jul 2020 21:03:19 +0200
Reto <reto@labrat.space> wrote:

> Hi,
> Thanks for the patch, some comments:
> 
> On Mon, Jul 20, 2020 at 10:31:10AM +0300, Tero Koskinen wrote:
> > error instead of panicing.
> typo, panicking

[PATCH] maildir: Provide nicer error message on invalid url 22 days ago

From Tero Koskinen to ~sircmpwn/aerc

If accounts.conf contains an invalid maildir url, return a nice
error instead of panicing.

Check a couple of different error cases to provide extra
information about the error to the user.
---
 worker/maildir/container.go | 26 +++++++++++++++++++++++---
 worker/maildir/worker.go    | 17 ++++++++++++++++-
 2 files changed, 39 insertions(+), 4 deletions(-)

diff --git a/worker/maildir/container.go b/worker/maildir/container.go
index cd9a447..170e917 100644
--- a/worker/maildir/container.go
+++ b/worker/maildir/container.go
[message trimmed]