~torresjrjr/public-inbox

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
4 2

[PATCH entr] language changes and switch expression fix

Details
Message ID
<20240411065815.19471-1-kurth4cker@gmail.com>
DKIM signature
pass
Download raw message
Patch: +4 -3
* for-each change
* never type
* switch expression should handle all possibilities

Signed-off-by: kurth4cker <kurth4cker@gmail.com>
---
 entr.ha | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/entr.ha b/entr.ha
index f35bc74..4f3c2ff 100644
--- a/entr.ha
+++ b/entr.ha
@@ -21,8 +21,7 @@ export fn main() void = {
	const cmd = getopt::parse(os::args, help...);
	defer getopt::finish(&cmd);

	for (let i = 0z; i < len(cmd.opts); i += 1) {
		const opt = cmd.opts[i];
	for (let opt .. cmd.opts) {
		switch (opt.0) {
		case 'a' =>
			abort("unimplemented option: -a");
@@ -40,6 +39,8 @@ export fn main() void = {
			abort("unimplemented option: -s");
		case 'z' =>
			abort("unimplemented option: -z");
		case =>
			abort();
		};
	};

@@ -54,7 +55,7 @@ export fn main() void = {
	const stat = os::exec::wait(&proc);
};

@noreturn fn usage(help: []getopt::help, flag: (rune | void)) void = {
fn usage(help: []getopt::help, flag: (rune | void)) never = {
	if (flag is rune) {
		fmt::errorfln("{}: invalid option parameter for -{}",
			os::args[0], flag: rune,
-- 
2.44.0
Details
Message ID
<D0HL0XWMLZHI.1IGD9A5FU9K61@torresjrjr.com>
In-Reply-To
<20240411065815.19471-1-kurth4cker@gmail.com> (view parent)
DKIM signature
pass
Download raw message
Hi Kurt,

As you can see, this is quite a dead project,
but thanks for the patch nonetheless.

Thanks. Applied to master, with some changes.

To git.sr.ht:~torresjrjr/entr
   4c40382..2c97aac  master -> master

commit 2c97aac207018b6291a1f0f4c386cc8e219e6406
Author: kurth4cker <kurth4cker@gmail.com>
Date:   Thu Apr 11 09:58:15 2024 +0300

    update per hare 0.24.0

    language changes and switch expression fix

    * for-each change
    * never type
    * switch expression should handle all possibilities

    Signed-off-by: kurth4cker <kurth4cker@gmail.com>
    Signed-off-by: Byron Torres <b@torresjrjr.com>
    Co-authored-by: Byron Torres <b@torresjrjr.com>
Details
Message ID
<Zhi8yR-hfLqgWQUL@altai>
In-Reply-To
<D0HL0XWMLZHI.1IGD9A5FU9K61@torresjrjr.com> (view parent)
DKIM signature
pass
Download raw message
On Thu, Apr 11, 2024 at 09:39:46PM +0100, Byron Torres wrote:
> As you can see, this is quite a dead project,
> but thanks for the patch nonetheless.

Yes I see. I'm just a newbie and excited about both email-based contributing
and hare itself. So I'm spending time on both of them. But thanks for apply
the patch.

Next time I can try other projects like I'm actively using or interested.
Details
Message ID
<D0I1XA0RJLR7.241VLUYIWECPN@torresjrjr.com>
In-Reply-To
<Zhi8yR-hfLqgWQUL@altai> (view parent)
DKIM signature
pass
Download raw message
On Fri Apr 12, 2024 at 4:47 AM UTC,  wrote:
> On Thu, Apr 11, 2024 at 09:39:46PM +0100, Byron Torres wrote:
> > As you can see, this is quite a dead project,
> > but thanks for the patch nonetheless.
>
> Yes I see. I'm just a newbie and excited about both email-based contributing
> and hare itself. So I'm spending time on both of them. But thanks for apply
> the patch.

Great.

> Next time I can try other projects like I'm actively using or interested.

Don't let me discourage you from contributing to dead projects. I was
just letting you and other readers of the mailing list know just in
case.
Details
Message ID
<Zhk3QivVIIJTdCY0@altai>
In-Reply-To
<D0I1XA0RJLR7.241VLUYIWECPN@torresjrjr.com> (view parent)
DKIM signature
pass
Download raw message
On Fri, Apr 12, 2024 at 09:54:18AM +0000, Byron Torres wrote:
> On Fri Apr 12, 2024 at 4:47 AM UTC,  wrote:
> > On Thu, Apr 11, 2024 at 09:39:46PM +0100, Byron Torres wrote:
> > > As you can see, this is quite a dead project,
> > > but thanks for the patch nonetheless.
> >
> > Yes I see. I'm just a newbie and excited about both email-based contributing
> > and hare itself. So I'm spending time on both of them. But thanks for apply
> > the patch.
> 
> Great.
> 
> > Next time I can try other projects like I'm actively using or interested.
> 
> Don't let me discourage you from contributing to dead projects. I was
> just letting you and other readers of the mailing list know just in
> case.

Thanks for explanation. No problem. I'm contributing because it's just funny.
Reply to thread Export thread (mbox)