~tristan957/public-inbox

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
2 2

[PATCH] Fix pagination

Details
Message ID
<20200623125332.11808-1-owen@devosmium.xyz>
DKIM signature
pass
Download raw message
Patch: +1 -1
Small error caused the pagination to try to put the previous page's URL
where the next page's should be, causing an error generating the first
page.
---
 layouts/_default/list.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/layouts/_default/list.html b/layouts/_default/list.html
index 5800688..25d0a3e 100644
--- a/layouts/_default/list.html
+++ b/layouts/_default/list.html
@@ -23,7 +23,7 @@
					</a>
				{{ end }}
				{{ if $paginator.HasNext }}
					<a class="btn btn-primary" style="float: right;" href="{{ $paginator.Prev.URL }}">
					<a class="btn btn-primary" style="float: right;" href="{{ $paginator.Next.URL }}">
						Page {{ $paginator.Next.PageNumber }}
						<span>
							<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 192 512">
-- 
2.27.0
Details
Message ID
<P005NXvMRVONeMYqiDNJRozq6Mc6XRR2DMZ5dOOwKhmHpH-eVVG_kcfOqRfgKq7WQpBdItLIeuuRSXU51-mCfNMEqU5-yPTOjOm8miWkFEA=@partin.io>
In-Reply-To
<20200623125332.11808-1-owen@devosmium.xyz> (view parent)
DKIM signature
pass
Download raw message
Owen,

I am so stupid! I never saw this email in my inbox. I have been
iterating on my website quite a bit recently, and finally got enough
blogs down to realize the mistake I made here. Ended up fixing other
pagination issues as well.

I ended up finding your blog. Cool that your site looks a lot like
mine. I made quite a few changes around how it is configured, so if
you wanted to pull updates from the source html files, it should be
much easier now.

Maybe at some point I will actually get a real Hugo theme going.

Any thoughts on GPL-3.0 vs AGPL-3.0 for personal websites like yours
and mine? I am currently going with the AGPL, but I feel like it
could be the wrong license.

Tristan

PS: I am pretty much a noob when it comes to mailing lists, so
partially why I missed your patch :).
Details
Message ID
<80f1590b-5e28-e8f2-7228-d03d089b9daa@devosmium.xyz>
In-Reply-To
<P005NXvMRVONeMYqiDNJRozq6Mc6XRR2DMZ5dOOwKhmHpH-eVVG_kcfOqRfgKq7WQpBdItLIeuuRSXU51-mCfNMEqU5-yPTOjOm8miWkFEA=@partin.io> (view parent)
DKIM signature
pass
Download raw message
Howdy,

On 2021-04-08 02:16, Tristan Partin wrote:
> Owen,
> 
> I am so stupid! I never saw this email in my inbox. I have been
> iterating on my website quite a bit recently, and finally got enough
> blogs down to realize the mistake I made here. Ended up fixing other
> pagination issues as well.
No worries! I figured at some point you'd need the fix.
> 
> I ended up finding your blog. Cool that your site looks a lot like
> mine. I made quite a few changes around how it is configured, so if
> you wanted to pull updates from the source html files, it should be
> much easier now.
Yeah, I've actually updated the theme because originally it was just 
your site theme with my content, so I changed it a bit to be simpler 
(commit a6d882d3)
> 
> Maybe at some point I will actually get a real Hugo theme going.
I mean, if it's not going to be distributed then I don't think it 
matters that much if you actually go through the trouble of a "proper" 
Hugo theme.
> 
> Any thoughts on GPL-3.0 vs AGPL-3.0 for personal websites like yours
> and mine? I am currently going with the AGPL, but I feel like it
> could be the wrong license.
I'm not a lawyer, but I think that AGPL is best for the code with CC 
BY-SA for the content.

Owen
Reply to thread Export thread (mbox)