On 2020-12-08 19:44, Nolan Prescott wrote:
> TRS-80 writes:
>> I am pretty sure this is because there is no provision to insert the
>> id when constructing the link in the render_link[1] and/or maybe the
>> render_plain_link[2] function(s).
> 
> The issue is in how the id attribute was added to the sanitizer
> whitelist. I've submitted a patch here:
> 
> https://lists.sr.ht/~sircmpwn/sr.ht-dev/patches/15867

I can confirm this is now working!  I pushed a small change in order to
regenerate the HTML to test.  Results (working in-page links generated
by org-md-export-to-markdown function) can now be seen at:

On 2020-12-03 11:07, Drew DeVault wrote:
> On Wed Dec 2, 2020 at 5:34 PM EST, TRS-80 wrote:
>> > On 2020-11-29 01:56, Eli Schwartz wrote:
>> >
>> > Looks like the inserted <a id=""> HTML markup is somehow getting
>> > dropped. I think this may be due to the bleach sanitizer configuration
>> > not whitelisting this for anything other than headers.
>> 
>> Is there some (security or other?) reason why the id attribute is
>> sanitized from anchor links?
> 
> It's just an oversight. We use a whitelist so we have to add everything
> we want. Patches welcome.

Sorry!  I forgot to add component to patch tag.  But I don't want to
kick off another build...

But I can send a fixed up v4 if you prefer?

Still getting the hang of this email workflow.  :/

Cheers,
TRS-80

---
Aah yes, good catch.  Sorry, I forgot to update that along with other
changes from v1 -> v2.

Will that be all that's needed?  No modifications to any of those
other functions?

Cheers,
TRS-80

 srht/markdown.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srht/markdown.py b/srht/markdown.py
[message trimmed]

---
Sorry, I forgot that "a" is already included in the default list of
bleach.sanitizer.ALLOWED_TAGS.[0]

Cheers,
TRS-80

[0] https://pythonhosted.org/bleach/clean.html#allowed-tags-tags

 srht/markdown.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srht/markdown.py b/srht/markdown.py
index 8929803..a724e4f 100644
[message trimmed]

---
Hello,

This is my first attempt at the patch Drew requested at the bottom of
this[0] thread.

I am pretty sure that this is not a complete solution.  I was looking
at the render_link functions for instance, but got a little lost at
that point to be perfectly honest.  My Python is only so-so.

But I am trying.  Any help would be greatly appreciated.  I am willing
to throw somebody some beer money, even.

Cheers,
[message trimmed]

---
Add some comment to email.

 TRS-80 | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 TRS-80

diff --git a/TRS-80 b/TRS-80
new file mode 100644
index 0000000..d52f14e
--- /dev/null
+++ b/TRS-80
@@ -0,0 +1 @@
+Test email comment
[message trimmed]

---
 TRS-80 | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 TRS-80

diff --git a/TRS-80 b/TRS-80
new file mode 100644
index 0000000..66cb3d4
--- /dev/null
+++ b/TRS-80
@@ -0,0 +1 @@
+I have successfully used git send-email!
-- 
2.29.2
[message trimmed]

---
 TRS-80 | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 TRS-80

diff --git a/TRS-80 b/TRS-80
new file mode 100644
index 0000000..6d0ecfd
--- /dev/null
+++ b/TRS-80
@@ -0,0 +1 @@
+I'm about to try git send-email
-- 
2.29.2
[message trimmed]

---
Test config setting of default email
---
 TRS-80 | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 TRS-80

diff --git a/TRS-80 b/TRS-80
new file mode 100644
index 0000000..3400c02
--- /dev/null
+++ b/TRS-80
@@ -0,0 +1 @@
+Test config setting of default email
[message trimmed]