France
Software engineer in love with Python and Go, paranoids about backups.
From Thomas Sileo to ~tsileo/microblog.pub-devel
Hey, I just applied this patch, thank you! (and sorry for the delay).
From Thomas Sileo to ~tsileo/microblog.pub-devel
Hey, that's a good point, I just applied the patch (and sorry for the delay). Thanks!
From Thomas Sileo to ~tsileo/microblog.pub-devel
I just realized we may be able to look at the `Accept` headers to determine if the browser supports webp, for example, my browser set this header when requesting an image: ``` image/avif,image/webp,*/* ``` I think this would be a better approach.
From Thomas Sileo to ~tsileo/microblog.pub-devel
Hey, I will try to take a look at this today. Not all the resized version are webp, for example we leave animated GIF alone, and if it fails, we fallback to the original picture. Can that be an issue if we specify the wrong type in the source tag? I am not sure we should hardcode the width, I think the CSS already handle that (and I don't want to break custom themes). And I think the patch as-is is breaking the microformats2 classes (for example `u-photo` mark a tag as a picture, I think having it on the `picture` tag may fail with some parser). But I can take care of testing that and tweak it if needed. I will keep you updated once I tested this/played with it. Thanks!
From Thomas Sileo to ~tsileo/microblog.pub-devel
Hey, Good catch, I just applied your patch. Thanks!
From Thomas Sileo to ~tsileo/microblog.pub-devel
Oops, that's a good catch, I just pushed a fix. It should re-use the recipients on the `Announce`: https://git.sr.ht/~tsileo/microblog.pub/commit/34c7cdb5fb9c5b681f91fd52c6323bb22c46a4ad Thanks!
From Thomas Sileo to ~tsileo/microblog.pub-devel
So, favicon, imgae_url and overriding individual blocks sounds ok to add in the doc. A single patch for the 3 above should be good. But I would wait about the stream customization, as I will change the API, I would like to wait until it's stable before it gets documented. Thank you!
From Thomas Sileo to ~tsileo/microblog.pub-devel
Hey, Thank you, I agree, since this it works right now, your edits in the documentation look correct (and I appreciate the "Advanced" notice), I just applied the patch. Thanks!
From Thomas Sileo to ~tsileo/microblog.pub-devel
Hey, I just applied the patch, thanks for your contribution!
From Thomas Sileo to ~tsileo/microblog.pub-devel
Hey, Thank you for this patch, it makes sense! I may add a tiny bit of JS to disable expanding when clicking on the text, but I think we can live with it. I just applied it. Thank you!