~tsileo/microblog.pub-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
3 3

[PATCH microblog.pub 0/1] Extend, don't overwrite, the emojis if setting custom ones

Details
Message ID
<166199584164.3803.13076275840044716282-0@git.sr.ht>
DKIM signature
missing
Download raw message
Hi @~tsileo,

I noticed that the recent (re)introduction of custom emojis actually
*replaces* the original ones, if custom ones are set.

I thought it might be better if the custom ones *extended* the default
list. This is, I believe, more aligned with what Mastodon instances do.

Feel free to reject it if you disagree! :)

Miguel Jacq (1):
  Extend the emojis with any custom-defined ones, don't replace the
    original ones

 app/config.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.34.4

[PATCH microblog.pub 1/1] Extend the emojis with any custom-defined ones, don't replace the original ones

Details
Message ID
<166199584164.3803.13076275840044716282-1@git.sr.ht>
In-Reply-To
<166199584164.3803.13076275840044716282-0@git.sr.ht> (view parent)
DKIM signature
missing
Download raw message
Patch: +1 -1
From: Miguel Jacq <mig@mig5.net>

---
 app/config.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/config.py b/app/config.py
index 4c1fe1f..c964ca0 100644
--- a/app/config.py
+++ b/app/config.py
@@ -154,7 +154,7 @@ KEY_PATH = (
)
EMOJIS = "😺 😸 😹 😻 😼 😽 🙀 😿 😾"
if CONFIG.emoji:
    EMOJIS = CONFIG.emoji
    EMOJIS += CONFIG.emoji

# Emoji template for the FE
EMOJI_TPL = '<img src="/static/twemoji/{filename}.svg" alt="{raw}" class="emoji">'
-- 
2.34.4

[microblog.pub/patches/.build.yml] build success

builds.sr.ht <builds@sr.ht>
Details
Message ID
<CMKOFWRWWZPC.26SIOLHAHYO8A@cirno>
In-Reply-To
<166199584164.3803.13076275840044716282-1@git.sr.ht> (view parent)
DKIM signature
missing
Download raw message
microblog.pub/patches/.build.yml: SUCCESS in 4m1s

[Extend, don't overwrite, the emojis if setting custom ones][0] from [~mig5][1]

[0]: https://lists.sr.ht/~tsileo/microblog.pub-devel/patches/35065
[1]: mig@mig5.net

✓ #836005 SUCCESS microblog.pub/patches/.build.yml https://builds.sr.ht/~tsileo/job/836005
Details
Message ID
<8ea8d320-b4d3-47e0-aca4-bc878ef57a0c@www.fastmail.com>
In-Reply-To
<166199584164.3803.13076275840044716282-0@git.sr.ht> (view parent)
DKIM signature
pass
Download raw message
Hey!

I am not entirely sure, I think it is nice to be able to replace the original list completely.

I may just tweak the user guide to show the default one if someone wants to just extend it.

I will see!

Thanks!
Reply to thread Export thread (mbox)