Ljubljana, Slovenia
From Bor Grošelj Simić to ~sircmpwn/hare-dev
Thanks! To git@git.sr.ht:~sircmpwn/harec 16bb1fb..65ba9fe master -> master
From Bor Grošelj Simić to ~sircmpwn/hare-dev
Pushed with a note about non-64bit platforms. Thanks! To git@git.sr.ht:~turminal/dotfiles 04ae538..8c88587 master -> master
From Bor Grošelj Simić to ~sircmpwn/hare-dev
Signed-off-by: Bor Grošelj Simić <bgs@turminal.net> --- src/check.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/check.c b/src/check.c index dbd81d6..a18f976 100644 --- a/src/check.c +++ b/src/check.c @@ -3207,7 +3207,7 @@ check_function(struct context *ctx, // TODO: Add function name to errors if (decl->func.flags != 0) { const char *flag; [message trimmed]
From Bor Grošelj Simić to ~sircmpwn/hare-dev
Previous checks for rt::compile return value succeeded in cases harec exited with SIGABRT or SIGSEGV and that resulted in masked bugs on multiple occasions. Signed-off-by: Bor Grošelj Simić <bgs@turminal.net> --- v2 -> v3: use a proper method of distinguishing exit-by-signal rt/compile.ha | 9 +++-- tests/00-constants.ha | 76 +++++++++++++++++++------------------- tests/01-arrays.ha | 10 ++--- tests/03-pointers.ha | 50 ++++++++++++------------- tests/05-implicit-casts.ha | 42 ++++++++++----------- tests/06-structs.ha | 4 +- tests/08-slices.ha | 24 ++++++------ [message trimmed]
From Bor Grošelj Simić to ~sircmpwn/hare-dev
Before this change we didn't properly check for presence of null type in some aggregate types and types of undefined or zero size weren't reported in places where they should be. Signed-off-by: Bor Grošelj Simić <bgs@turminal.net> --- include/type_store.h | 9 +-- src/check.c | 31 +++++---- src/eval.c | 2 +- src/type_store.c | 150 +++++++++++++++++++++++++++++++------------ tests/03-pointers.ha | 11 ++++ tests/06-structs.ha | 4 ++ 6 files changed, 151 insertions(+), 56 deletions(-) [message trimmed]
From Bor Grošelj Simić to ~sircmpwn/hare-dev
Signed-off-by: Bor Grošelj Simić <bgs@turminal.net> --- include/type_store.h | 4 +-- src/check.c | 14 +++++---- src/type_store.c | 71 ++++++++++++++++++++++++++++++++++---------- tests/13-tagged.ha | 14 +++++++++ 4 files changed, 79 insertions(+), 24 deletions(-) diff --git a/include/type_store.h b/include/type_store.h index 4c53d77..8b095ea 100644 --- a/include/type_store.h +++ b/include/type_store.h @@ -20,7 +20,7 @@ struct type_store { [message trimmed]
From Bor Grošelj Simić to ~sircmpwn/hare-dev
Calloc and realloc may return NULL during normal operation if the requested size is 0. Signed-off-by: Bor Grošelj Simić <bgs@turminal.net> --- src/util.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util.c b/src/util.c index 6fb5f82..2407660 100644 --- a/src/util.c +++ b/src/util.c @@ -63,7 +63,7 @@ void * xcalloc(size_t n, size_t s) [message trimmed]
From Bor Grošelj Simić to ~sircmpwn/hare-dev
Replying to Drew DeVault's feedback that accidentially got sent to the wrong thread: > I don't really like hacky temporary fixes. Does this come up in practice > sufficiently often to demand an urgent fix? Or can we just ignore it > until a better solution is found? In theory this bug affects a big enough set of dependency configurations that I'd even prefer reverting that change entirely over letting it stay unfixed for some period of time. In practice it only came up once in over two weeks, so it's probably not really that urgent.
From Bor Grošelj Simić to ~sircmpwn/hare-dev
On Fri Jun 24, 2022 at 1:03 PM CEST, Drew DeVault wrote: > I don't really like hacky temporary fixes. Does this come up in practice > sufficiently often to demand an urgent fix? Or can we just ignore it > until a better solution is found? Did you intend to send this feedback to https://lists.sr.ht/~sircmpwn/hare-dev/patches/33084 ?
From Bor Grošelj Simić to ~sircmpwn/hare-dev
This one was applied by me a few days ago.