~vdupras/duskos-discuss

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
3 2

[PATCH 1/3] Update 'code' doc

Details
Message ID
<20230618201209.24398-1-alex@alexwennerberg.com>
DKIM signature
missing
Download raw message
Patch: +1 -1
Found this a bit unclear, since my understanding is isn't exactly the
same as entry (it does not take a dict param but refers to sysdict
---
 fs/doc/dict.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/doc/dict.txt b/fs/doc/dict.txt
index 3cb3d79..5891ae0 100644
--- a/fs/doc/dict.txt
+++ b/fs/doc/dict.txt
@@ -276,7 +276,7 @@ w>e        w -- e    Yield an entry (linked list pointer) from a word reference.
e>w        e -- w    Yield a word reference (executable) from an entry.
entry      'dict s --
                     Create entry with name s in dictionary 'dict.
code       "x" --    Same as "entry", but reads name from input stream.
code       "x" --    Create entry with from input stream in sysdict.
code8b     --        Create a 8b variant to the latest word.
code16b    --        Create a 16b variant to the latest word.
current    -- w      Yield the last word to be added to the system dictionary.
-- 
2.40.1

[PATCH 2/3] Clarify null byte escape sequence

Details
Message ID
<20230618201209.24398-2-alex@alexwennerberg.com>
In-Reply-To
<20230618201209.24398-1-alex@alexwennerberg.com> (view parent)
DKIM signature
missing
Download raw message
Patch: +1 -1
---
 fs/doc/usage.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/doc/usage.txt b/fs/doc/usage.txt
index aafd043..b2ea897 100644
--- a/fs/doc/usage.txt
+++ b/fs/doc/usage.txt
@@ -68,7 +68,7 @@ character:

\n: newline ($0a)
\r: carriage return ($0d)
\0: 0
\0: null byte (0)
\\: '\' character
\": '"' character

-- 
2.40.1

[PATCH 3/3] Add reference to "counted string"

Details
Message ID
<20230618201209.24398-3-alex@alexwennerberg.com>
In-Reply-To
<20230618201209.24398-1-alex@alexwennerberg.com> (view parent)
DKIM signature
missing
Download raw message
Patch: +4 -3
---
 fs/doc/usage.txt | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/fs/doc/usage.txt b/fs/doc/usage.txt
index b2ea897..9ab418a 100644
--- a/fs/doc/usage.txt
+++ b/fs/doc/usage.txt
@@ -46,9 +46,10 @@ Dusk has no DEC/HEX mode. Number literals are parsed using a prefix system.

## Strings

A string is an address to an area in memory starting with a length byte followed
by that many bytes. When we refer to a "string", we refer to that address.  For
example, this code will yield a "hello" string to PS (Parameter Stack):
A string is an address to an area in memory starting with a length byte
followed by that many bytes (also known as a "counted string"). When we refer
to a "string", we refer to that address.  For example, this code will yield a
"hello" string to PS (Parameter Stack):

here 5 c, 'h' c, 'e' c, 'l' c, 'l' c, 'o' c,

-- 
2.40.1
Details
Message ID
<b2b0b85a-d348-4c79-9ea8-ce1fa0186574@app.fastmail.com>
In-Reply-To
<20230618201209.24398-1-alex@alexwennerberg.com> (view parent)
DKIM signature
missing
Download raw message
On Sun, Jun 18, 2023, at 4:12 PM, alex wennerberg wrote:
> Found this a bit unclear, since my understanding is isn't exactly the
> same as entry (it does not take a dict param but refers to sysdict
> ---
>  fs/doc/dict.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/doc/dict.txt b/fs/doc/dict.txt
> index 3cb3d79..5891ae0 100644
> --- a/fs/doc/dict.txt
> +++ b/fs/doc/dict.txt
> @@ -276,7 +276,7 @@ w>e        w -- e    Yield an entry (linked list 
> pointer) from a word reference.
>  e>w        e -- w    Yield a word reference (executable) from an entry.
>  entry      'dict s --
>                       Create entry with name s in dictionary 'dict.
> -code       "x" --    Same as "entry", but reads name from input stream.
> +code       "x" --    Create entry with from input stream in sysdict.
>  code8b     --        Create a 8b variant to the latest word.
>  code16b    --        Create a 16b variant to the latest word.
>  current    -- w      Yield the last word to be added to the system 
> dictionary.
> -- 
> 2.40.1

Thanks, merged.
Reply to thread Export thread (mbox)