I'm trying to review squares in area 2521, and I was able to get through 
a few of them, but now it just displays this error:

no square to CreateCommitType.REVIEW_OLDEST

(or similar for each other ordering choices)

despite the fact that it still shows "35% to review"

Nice catch, thanks!

> -    server.await?;
> -
> -    Ok(())
> +    server.await.map_err(From::from)
>  }
Hmm, I'm not sure what I think about this. I used the Ok(()) here to
avoid explicitly writing error conversion

While there are currently cases where hitide sanitizes content, this is
a hold-over from before lotide did sanitization. This should actually be
implemented there instead, and then frontends can trust the API response
as-is

>  #[tokio::main]
>  async fn main() -> Result<(), Box<dyn std::error::Error>> {
> +    let _ = env_logger::init();

Is assigning this necessary? Doesn't it just return ()?

All errors in lotide are eventually represented by the Error struct from
src/main.rs. UserError and RoutingError are the only variants that are
returned to clients, the others are converted to 500. In this case, I
think the best path would be to change route_unstable_actors_lookup to
return a UserError if `parse_lookup` fails. Alternately, maybe it should
just return an empty array in this case since it's basically still a
"not found"

We certainly can't just embed untrusted HTML, but this is the same
situation as post content, which lotide sanitizes with ammonia before
returning in the API. Probably should do the same with user descriptions
and then it would be okay to render them

On 20-12-25 06:35, Matthias Beyer wrote:
> Would you accept patches to add .service files?
> 

Sure, that seems reasonable

Using a background color here feels out of place somehow, but I do like
the idea of improving visual distinction for comments & post content.

Just pushed an attempt at doing this more subtly, what do you think?

On 20-12-23 16:08, Matthias Beyer wrote:
> Hi,
> 
> I just found this project today and (as you can see by me firing patches) am 
> falling in love with it already.
> 
> I would like to ask what the plans for hitide are in general? I feel like that 
> the goal is to provide a javascript-free user interface with a minimal style, 
> is that correct?
> I would love that! Would you mind a few minor visual tweaks, tho? Just CSS of 
> course! I would love to play around with the UI design a bit (I am no way a UI 
> person) to see what I can do and would then propose it here!

hitide will never require javascript to use but at some point will