~vpzom/lotide

hitide: Add placeholder attribute to forms v2 REJECTED

William Culhane: 1
 Add placeholder attribute to forms

 1 files changed, 2 insertions(+), 0 deletions(-)
Export patchset (mbox)
How do I use this?

Copy & paste the following snippet into your terminal to import this patchset into git:

curl -s https://lists.sr.ht/~vpzom/lotide/patches/11661/mbox | git am -3
Learn more about email & git
View this thread in the archives

[PATCH hitide v2] Add placeholder attribute to forms Export this patch

---
Resubmitted with subject line fixed for sourcehut.

 src/components/mod.rs | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/components/mod.rs b/src/components/mod.rs
index 9ef867b..44079b0 100644
--- a/src/components/mod.rs
+++ b/src/components/mod.rs
@@ -354,6 +354,7 @@ pub fn MaybeFillInput<'a, M: GetIndex<&'a str, serde_json::Value>>(
                r#type
                name
                value
                placeholder={name}
                required={""}
            />
        }
@@ -363,6 +364,7 @@ pub fn MaybeFillInput<'a, M: GetIndex<&'a str, serde_json::Value>>(
                r#type
                name
                value
                placeholder={name}
            />
        }
    }
-- 
2.27.0
The `name` value isn't meant to be user-facing, so I don't think it should be shown in forms. I'm also not sure I want to use placeholder at all, since anything there disappears if the user enters any text

On Sat, Jul 18, 2020, at 20:08, William Culhane wrote: