~wgr

Recent activity

Re: [PATCH] notmuch/maildir: remove double emit of the dirinfo 16 days ago

From wagner riffel to ~sircmpwn/aerc

On Wed Apr 28, 2021 at 3:01 AM -03, Reto Brunner wrote:
> @Wagner: Happy with me including your name?
>

Sure thing, no problem.
The patch LGTM.

Re: [PATCH] maildir: fix race condition in openDirectory 18 days ago

From wagner riffel to ~sircmpwn/aerc

On Mon Apr 26, 2021 at 4:34 PM -03, Reto wrote:
> I can't reproduce the error anymore with the event loop stalling at
> least in
> the notmuch worker.
>
> Can you try what happens if you simply remove the double emit of the
> event?
> It's clearly the wrong thing to do anyhow.
>

Hi Reto, I think I mentioned this on the patch email, I did test and
actually I'm using for some weeks this exact approach, I just deleted
the second emit, I see no apparent problems so far.

Re: [PATCH] maildir: fix race condition in openDirectory 18 days ago

From wagner riffel to ~sircmpwn/aerc

Hey Reto, friendly pinging, in case you missed my reply, it's been
over 15 days since your last reply and I'm willing to work on changes
to get this merged.

Best Regards

--wagner

Re: [PATCH] maildir: fix race condition in openDirectory a month ago

From wagner riffel to ~sircmpwn/aerc

On Mon Apr 12, 2021 at 1:54 PM -03, Reto wrote:
> Do you want to have a look? I'd appreciate it.
>

Here's what I could dig when I was investigating this:

We send the first message here from the worker goroutine:
https://git.sr.ht/~sircmpwn/aerc/tree/a5553438/item/worker/maildir/worker.go#L306

Then Tick() is waked in the main goroutine and calls ProcessMessage:
https://git.sr.ht/~sircmpwn/aerc/tree/a5553438/item/widgets/account.go#L100

ProcessMessage in the main goroutine reads types.Message state with
msg.getId() and msg.InResponseTo():
[message trimmed]

[PATCH] maildir: fix race condition in openDirectory a month ago

From wagner riffel to ~sircmpwn/aerc

Signed-off-by: wagner riffel <w@104d.net>
---
This race condition happens often while aerc is openning a maildir
directory, deleteing this second PostMessage calls also works, but
right above there is a comment it has to be sent twice for some
unknown reason, so i left the second send but using a copy of info
instead.
 worker/maildir/worker.go | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/worker/maildir/worker.go b/worker/maildir/worker.go
index 4a7ae51..094856c 100644
--- a/worker/maildir/worker.go
+++ b/worker/maildir/worker.go
[message trimmed]

[PATCH] config: proper error handle [filters] config a month ago

From wagner riffel to ~sircmpwn/aerc

Instead of panic when compiling a regular expression, return it up

Signed-off-by: wagner riffel <w@104d.net>
---
 config/config.go | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/config/config.go b/config/config.go
index 8b409fe..8032201 100644
--- a/config/config.go
+++ b/config/config.go
@@ -304,7 +304,7 @@ func (config *AercConfig) LoadConfig(file *ini.File) error {
				filter.Header = strings.ToLower(header)
				filter.Regex, err = regexp.Compile(regex)
[message trimmed]

Re: [PATCH] Adds FIFO support a month ago

From wagner riffel to ~sircmpwn/aerc

On Mon Mar 29, 2021 at 3:19 AM UTC, Sebastian wrote:
> This commit give aerc the ability to read commands through a FIFO
> (named pipe). A configuration option in aerc.conf is added in the
> general section called `fifo-path`, which takes in a string for the
> destination of the FIFO. The default is /usr/share/aerc/fifo. Text
> written to the FIFO is interpreted as a command and immediately
> executed by aerc.
> ---

This ability through a pipe is quite unusual, there is any other email
client that has this feature? I think that if we instead take a
"commands" file to be executed as an argument, would be more roboust
than all the bookkeeping involved with the fifo file; (configuration,
stat, create, remove...) So aerc could work as the usual way to use

[PATCH] plugins/caldav: remove statements not used 11 months ago

From Wagner Riffel to ~emersion/alps-dev

Signed-off-by: Wagner Riffel <wgrriffel@gmail.com>
---
 plugins/caldav/routes.go | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/plugins/caldav/routes.go b/plugins/caldav/routes.go
index 3e4fa71..020882e 100644
--- a/plugins/caldav/routes.go
+++ b/plugins/caldav/routes.go
@@ -111,11 +111,6 @@ func registerRoutes(p *alps.GoPlugin, u *url.URL) {
			return err
		}

		c, err := newClient(u, ctx.Session)
[message trimmed]

[PATCH] plugins/caldav: remove statements not used 11 months ago

From Wagner Riffel to ~migadu/alps-devel

Signed-off-by: Wagner Riffel <wgrriffel@gmail.com>
---
 plugins/caldav/routes.go | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/plugins/caldav/routes.go b/plugins/caldav/routes.go
index 3e4fa71..020882e 100644
--- a/plugins/caldav/routes.go
+++ b/plugins/caldav/routes.go
@@ -111,11 +111,6 @@ func registerRoutes(p *alps.GoPlugin, u *url.URL) {
			return err
		}

		c, err := newClient(u, ctx.Session)
[message trimmed]

Re: [PATCH 2/2] f32: add package Rect shorthand function 1 year, 1 day ago

From wagner riffel to ~eliasnaur/gio-patches

On Wed, 13 May 2020 13:08:34 +0200
"Elias Naur" <mail@eliasnaur.com> wrote:

> Do you find yourself needing Rect often in your work?

Hi Elias, I've been playing with gio just past two weeks, thus I lack
enough experience with gio to give you any useful feedback regarding
the need of Rect, I noticed the "lack" of Rect and fmt.Stringer because
I'm familiarized with image package, which had both functions and I felt
for "compatibility" reasons would be nice to have. However I do
understand your concerns regarding usefulness and clarity and it's such
small function that I don't mind maintaining internally in my package,
feel free to reject this patch.