guixrus: guixrus: packages: Add iredis. v1 SUPERSEDED

Stephen Paul Weber: 1
 guixrus: packages: Add iredis.

 1 files changed, 91 insertions(+), 0 deletions(-)

[PATCH guixrus] guixrus: packages: Add iredis. Export this patch

* guixrus/packages/iredis.scm (iredis): New variable.
* guixrus/packages/iredis.scm (python-mistune): New variable.
---
 guixrus/packages/iredis.scm | 91 +++++++++++++++++++++++++++++++++++++
 1 file changed, 91 insertions(+)
 create mode 100644 guixrus/packages/iredis.scm

diff --git a/guixrus/packages/iredis.scm b/guixrus/packages/iredis.scm
new file mode 100644
index 0000000..4ed5e62
--- /dev/null
+++ b/guixrus/packages/iredis.scm
@@ -0,0 +1,91 @@
+;;; GNU Guix --- Functional package management for GNU
+;;;
+;;; Copyright © 2022 Stephen Paul Weber <singpolyma@singpolyma.net>
+;;; This file is not part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (guixrus packages iredis)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix build-system python)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (gnu packages python-xyz)
+  #:use-module (gnu packages check)
+  #:use-module (gnu packages databases)
+  #:use-module (gnu packages time))
+
+(define-public python-mistune
+  (package
+    (name "python-mistune")
+    (version "2.0.3")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "mistune" version))
+              (sha256
+               (base32
+                "0l3yddym9mg94mfssc21xbs00vwsn8154iiasnvm6sqmnr35nq6p"))))
+    (build-system python-build-system)
+    (arguments
+     '(#:tests? #f

( <paren@disroot.org>

1 year, 2 months ago

Could you please use the (list #:foo #~(...) #:bar #~(...)) gexps form
here instead?

Next

+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'add-setup-py
+           (lambda args

( <paren@disroot.org>

1 year, 2 months ago

`(lambda _` would be better here, since we don't use the arguments.

Next

+             (with-output-to-file "setup.py"
+               (lambda _ (display "from setuptools import setup\nif __name__ == '__main__':\n    setup()"))))))))

( <paren@disroot.org>

1 year, 2 months ago

This line is a bit long :)

Next

+    (native-inputs (list python-setuptools))
+    (home-page "https://github.com/lepture/mistune")
+    (synopsis "A sane Markdown parser with useful plugins and renderers")
+    (description
+     "This package provides a sane Markdown parser with useful plugins and renderers")
+    (license license:bsd-3)))

( <paren@disroot.org>

1 year, 2 months ago

I think "sane" is a little markety, implying the rest aren't sane.

Next

+
+(define-public iredis
+  (package
+    (name "iredis")
+    (version "1.12.0")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "iredis" version))
+              (sha256
+               (base32
+                "10fdf6w6q21960l0bk4n5aa03sfk6877bgprnr43v80avfa100y3"))))
+    (build-system python-build-system)
+    (arguments
+     '(#:phases

( <paren@disroot.org>

1 year, 2 months ago

Gexps here too.

Next

+       (modify-phases %standard-phases
+         (add-after 'unpack 'loosen-dependencies
+           (lambda args

( <paren@disroot.org>

1 year, 2 months ago

Use `(lambda _` here too.

Next

+             (substitute* "setup.py"
+               (("wcwidth==0.1.9") "wcwidth>=0.1.8")
+               (("5.1.0") "3.0.0")))))))
+    (propagated-inputs (list python-click-7
+                             python-configobj
+                             python-importlib-resources
+                             python-mistune
+                             python-packaging
+                             python-pendulum
+                             python-prompt-toolkit
+                             python-pygments
+                             python-redis
+                             python-wcwidth))
+    (native-inputs
+      (list python-pytest python-pexpect))
+    (home-page "https://github.com/laixintao/iredis")
+    (synopsis
+     "Terminal client for Redis with auto-completion and syntax highlighting.")

( <paren@disroot.org>

1 year, 2 months ago

Shouldn't have a period at the end, according to `guix lint`.

Next

+    (description
+     "Terminal client for Redis with auto-completion and syntax highlighting.")

( <paren@disroot.org>

1 year, 2 months ago

This is the same as the synopsis. Could you write a longer description
here?

Side note: Am I being too strict about code style? Seems like guixrus's
standards are intentionally lower so that it can act as a staging area
for packages that aren't guix-quality. If you think I shouldn't be
treating this like a patch sent to guix-patches, please let me know! :)

    -- (

+    (license license:bsd-3)))
-- 
2.30.2

builds.sr.ht <builds@sr.ht>

1 year, 2 months ago

guixrus/patches/.build.yml: SUCCESS in 21m37s

[guixrus: packages: Add iredis.][0] from [Stephen Paul Weber][1]

[0]: https://lists.sr.ht/~whereiseveryone/guixrus/patches/33324
[1]: mailto:singpolyma@singpolyma.net

✓ #789065 SUCCESS guixrus/patches/.build.yml https://builds.sr.ht/~whereiseveryone/job/789065

( <paren@disroot.org>

1 year, 2 months ago

Hi singpolyma,