The Netherlands
From Hugo Osvaldo Barrera to ~delthas/senpai-dev
I didn't include 'on-highlight-notify' in my config (i.e.: I let the default kick in), and notifications still work as expected. Tested-by: Hugo Osvaldo Barrera <hugo@whynothugo.nl> -- Hugo
From Hugo Osvaldo Barrera to ~soywod/pimalaya
Clap can do most of the argument parsing for us, which allows dropping lots of parsing code and simplifying the argument-parsing logic. I tried to keep the same general structure in order to keep this diff easy to read. In reality, the CompileCommand and InterpreterCommand should just take an Option<PathBuf> as parameter, and actually reading the file should be done as part of the command execution -- but that change would have been quite invasive in an already invasive patch, so I've left that out of scope for now. --- v2: Set the command name to `mml`, like in f71d1534 Cargo.lock | 14 ++++ Cargo.toml | 1 + src/compl/args.rs | 37 ++------- [message trimmed]
From Hugo Osvaldo Barrera to ~soywod/pimalaya
Clap can do most of the argument parsing for us, which allows dropping lots of parsing code and simplifying the argument-parsing logic. I tried to keep the same general structure in order to keep this diff easy to read. In reality, the CompileCommand and InterpreterCommand should just take an Option<PathBuf> as parameter, and actually reading the file should be done as part of the command execution -- but that change would have been quite invasive in an already invasive patch, so I've left that out of scope for now. --- Cargo.lock | 14 ++++ Cargo.toml | 1 + src/compl/args.rs | 37 ++------- src/main.rs | 64 +++++++--------- [message trimmed]
From Hugo Osvaldo Barrera to ~soywod/pimalaya
The generated man page and completion scripts use the command name as a base. With the command name being "mml-cli", the completion scripts don't work as expected. This fixes the completion scripts and man pages. --- src/main.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main.rs b/src/main.rs index 5b925d3..026a84e 100644 --- a/src/main.rs +++ b/src/main.rs @@ -8,7 +8,7 @@ use env_logger::{Builder as LoggerBuilder, Env, DEFAULT_FILTER_ENV}; [message trimmed]
From Hugo Osvaldo Barrera to ~soywod/pimalaya
This makes navigating from crates.io and docs.rs a bit easier. --- email-tpl/Cargo.toml | 2 ++ email/Cargo.toml | 2 ++ keyring/Cargo.toml | 2 ++ maildir++/Cargo.toml | 2 ++ mml/Cargo.toml | 2 ++ oauth2/Cargo.toml | 2 ++ pgp/Cargo.toml | 2 ++ process/Cargo.toml | 2 ++ secret/Cargo.toml | 2 ++ time/Cargo.toml | 2 ++ 10 files changed, 20 insertions(+) [message trimmed]
From Hugo Osvaldo Barrera to ~delthas/senpai-dev
Use the user's current locale to format dates (e.g.: based on LC_ALL or LC_TIME). Given that dates have variable lengths, move them onto their own separate line. --- go.mod | 2 +- go.sum | 13 ++++++++-- ui/buffers.go | 20 +++++++++------- ui/draw_utils.go | 62 ++++-------------------------------------------- 4 files changed, 28 insertions(+), 69 deletions(-) diff --git a/go.mod b/go.mod index 22e4cc0..fa0d016 100644 --- a/go.mod +++ b/go.mod [message trimmed]
From Hugo Osvaldo Barrera to ~delthas/senpai-dev
--- ui/ui.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/ui.go b/ui/ui.go index b463089..e4c1b68 100644 --- a/ui/ui.go +++ b/ui/ui.go @@ -458,8 +458,8 @@ func (ui *UI) Size() (int, int) { return ui.screen.Size() } func (ui *UI) Beep() { ui.screen.Beep() [message trimmed]
From Hugo Osvaldo Barrera to ~delthas/senpai-dev
--- completions.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/completions.go b/completions.go index 4c8ff28..bac653d 100644 --- a/completions.go +++ b/completions.go @@ -113,7 +113,7 @@ func (app *App) completionsCommands(cs []ui.Completion, cursorIdx int, text []ru } uText := strings.ToUpper(string(text[1:cursorIdx])) for name, _ := range commands { for name := range commands { [message trimmed]
From Hugo Osvaldo Barrera to ~delthas/senpai-dev
--- app.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app.go b/app.go index 509a518..fde594e 100644 --- a/app.go +++ b/app.go @@ -262,7 +262,7 @@ func (app *App) eventLoop() { if netID != "" && buffer != "" { app.win.SetTitle(fmt.Sprintf("%s — senpai", buffer)) } else { app.win.SetTitle(fmt.Sprintf("senpai")) app.win.SetTitle("senpai") [message trimmed]
From Hugo Osvaldo Barrera to ~soywod/pimalaya
Use the common /usr/sbin/sendmail the default. This is a common default hardcoded in many applications. Fixes: https://todo.sr.ht/~soywod/pimalaya/126 --- src/config/prelude.rs | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/config/prelude.rs b/src/config/prelude.rs index cf9c443..adc192f 100644 --- a/src/config/prelude.rs +++ b/src/config/prelude.rs @@ -368,10 +368,18 @@ pub enum SmtpOAuth2ScopesDef { #[derive(Clone, Debug, Eq, PartialEq, Serialize, Deserialize)] [message trimmed]