On Sat, 22 Mar 2025, at 19:55, Armin Preiml wrote:
> […]
> +
> +*set* __query__...
> +	Requires a preceeding *update* command. Changes the key/value pairs of
> +	the keys that are matched by the update command according to the values
> +	provided by the query. If a key/value pair doesn't exist, it will be
> +	added. Otherwise the existing key will be updated with the new value,
> +	except if there is no value. Then the key/value pair will be removed.
> +

I'm not a huge fan of deleting pairs that are missing from the query, because
it means that updating a single field requires repeating all of them. If I'm
updating a non-secret field, then I need to read secret fields first and

---
 src/himitsu/client.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/himitsu/client.py b/src/himitsu/client.py
index 62c2788..e2fc214 100644
--- a/src/himitsu/client.py
+++ b/src/himitsu/client.py
@@ -90,7 +90,7 @@ class Client:
     def lock(self, soft=False) -> None:
         """Locks the himitsu daemon, which removes all values from memory
         
-        If soft is provided, the daemon willl keep public attributes.
+        If soft is provided, the daemon will keep public attributes.
[message trimmed]

---
 src/himitsu/client.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/himitsu/client.py b/src/himitsu/client.py
index c1f7a2d..62c2788 100644
--- a/src/himitsu/client.py
+++ b/src/himitsu/client.py
@@ -75,7 +75,7 @@ class Client:
 
             for strentry in strentries:
                 if not strentry.startswith("key "):
-                    return Exception("invalid response")
+                    raise Exception("invalid response")
[message trimmed]

Eases understanding of the exact return type for each function and
allows type-checking application code which uses this library.
---
 src/himitsu/client.py | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/himitsu/client.py b/src/himitsu/client.py
index 00c75b1..c1f7a2d 100644
--- a/src/himitsu/client.py
+++ b/src/himitsu/client.py
@@ -1,7 +1,7 @@
 from enum import Enum
 from enum import StrEnum
 from xdg import BaseDirectory
[message trimmed]

Applied, thanks.

-- 
Hugo

On 2025-03-21 16:08, Michiel van den Heuvel wrote:
> I noticed that building on macOS was broken since pulling the last few
> days of commits. This should fix that.
> […]

Thanks for catching this. Applied.

-- 
Hugo

On Wed, 19 Mar 2025, at 11:52, Drew DeVault wrote:
> I have a pretty significant refactoring in mind. If you're volunteering
> to work on it I can prepare a write-up for sr.ht-dev?

I'll start having more availability during April, and this affects a few
projects which I need to test on 32bit arches. I'm willing to take a
shot at it.

-- 
Hugo

Allows filtering messages to those of a given user. E.g.: when user
session services log to syslog.

Allows distinguishing between logs from different users on multi-user
systems.

Use NULL when the UID is unknown. This is the default value which
applies to existing entries.
---
v3: remove pointless heap allocation for each message introduced in v2
 main.c | 82 ++++++++++++++++++++++++++++++++++++++++++++++++++--------
 1 file changed, 71 insertions(+), 11 deletions(-)

diff --git a/main.c b/main.c
[message trimmed]

Allows filtering messages to those of a given user. E.g.: when user
session services log to syslog.

Allows distinguishing between logs from different users on multi-user
systems.

Use NULL when the UID is unknown. This is the default value which
applies to existing entries.
---
 main.c | 83 ++++++++++++++++++++++++++++++++++++++++++++++++++--------
 1 file changed, 72 insertions(+), 11 deletions(-)

diff --git a/main.c b/main.c
index b477e1a..08a0a10 100644
[message trimmed]

Hi Martijn,

On 2025-03-17 22:09, Martijn Braam wrote:
> This is a great feature, thanks for the patch. I've written some notes
> inline.
> 
> On 3/16/25 3:38 PM, Hugo Osvaldo Barrera wrote:
> > Store the UID of processes which log via the syslog interface.
> > […]
> > @@ -27,6 +28,9 @@
> >   #include "shared.h"
> >   #include "parser.h"
> > +// Ensure that uid_t is uint32.
> > +_Static_assert(sizeof(uid_t) * CHAR_BIT == 32, "uid_t must be uint32");