~whynothugo/superd-services

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch

[PATCH] swww: remove ".target" dependency and WantedBy

Details
Message ID
<20231004233716.8959-1-sam@samnystrom.dev>
DKIM signature
missing
Download raw message
Patch: +0 -4
superd panics if dependencies don't end with ".service" and does not
implement WantedBy.
---
After upgrading superd-services to 0.8.0, superd no longer started for
me because of this panic. See
https://git.sr.ht/~craftyguy/superd/tree/master/item/internal/config/parse.go#L162
for the relevant error handling code in superd.

I noticed a few other issues but didn't change them in this patch since
I don't use and can't test swww.
- swww's service file uses an absolute path, which is discouraged in the
  README.
- The "Documentation" field references a file which is not packaged by
  Alpine.

 swww.service | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/swww.service b/swww.service
index 4f54751..0abac8f 100644
--- a/swww.service
+++ b/swww.service
@@ -1,10 +1,6 @@
[Unit]
Description=Solution to Wayland Wallpaper Woes
Documentation=file:/usr/share/doc/swww/README.md
After=graphical-session.target

[Service]
ExecStart=/usr/bin/swww init --no-daemon

[Install]
WantedBy=graphical-session.target
-- 
2.42.0
Reply to thread Export thread (mbox)