This is the comment thread for the article "Why Transit? 2024 Week
Without Driving", published October 6, 2024.

Link: https://www.vincent-lee.net/blog/2024-10-06-week-without-driving/

Please reply under this email with any comments you have for this post.

idk what the actual bug is here but sure. Pushed.

wenming.yi@gmail.com writes:

> From: Alwinfy <20421383+Alwinfy@users.noreply.github.com>
>
> bug's been bothering me for years now and it's a one line fix
>
> ---
>  backend.rkt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/backend.rkt b/backend.rkt
> index 17ecd92..3a1276f 100644

Pushed with a small compile fix

wenming.yi@gmail.com writes:

> From: Alwinfy <20421383+Alwinfy@users.noreply.github.com>
>
> fix a use-define oopsies.
>
> also destructure the regex match because "people don't like caadrs winfy".
> 1984.
>
> ---
>  frontends/discord.rkt | 44 ++++++++++++++++++++++++++++++++++---------
>  scribblings/r16.scrbl |  1 +

See inline for a question.

Maybe to generalize, you might want to name this "allowed_bots" and let
the prefix-stripping regex to be customizable.

Also, please update the scribble docs.

wenming.yi@gmail.com writes:

> From: Alwinfy <20421383+Alwinfy@users.noreply.github.com>
>
> This patch allow IRCs users (hello #tech_chat!) to use r16.
>

Artemis System <theartemissystem@gmail.com> writes:

> This leads to some changes:
> - Runic altar and mana pools no longer store a cooldown, just a boolean. Meaning items will never re-enter the pool/altar before being picked up if they happen to land on top of it again.
> - Hopperhocks' 5 tick pickup delay now applies to items spawned from alfheim portals and petal apothecaries, not just altars and mana pools.

lgtm, but make sure to document the gameplay-facing changes in the
changelog eventually

> ---
>  .../AlfheimPortalBlockEntity.java             |  5 +-
>  .../PetalApothecaryBlockEntity.java           |  2 -
>  .../block_entity/RunicAltarBlockEntity.java   |  6 +-
>  .../mana/ManaPoolBlockEntity.java             |  4 +-

Artemis System <theartemissystem@gmail.com> writes:

> Probably predates the cooldown item flag which applies to specific items, and has no real reason to exist anymore, from what i can tell. Also removes the particle effect that plays in the cooldown, it was so subtle that i didn't even know it existed

I'm fine with removing the functional purpose of the cooldown, but I
liked the "smoking" particles as a nice effect. Can we keep that?

> ---
> New patch upcoming to address that the specific item cooldown is shorter than the now
> removed cooldown
> .../block_entity/RunicAltarBlockEntity.java   | 24 ++++---------------
>  1 file changed, 4 insertions(+), 20 deletions(-)
>

lgtm, but make sure to update the HUD render to render the right reagent
instead of livingrock now.

Artemis System <theartemissystem@gmail.com> writes:

> Not used yet, will be used in a future commit
> ---
> Figured i'll just send these one by one, more commits incoming
>  .../cc3f2b57729a50761cd506b810b841f2b4fbd4d1  | 34 ++++++-------
>  .../data/botania/recipes/runic_altar/air.json |  3 ++
>  .../botania/recipes/runic_altar/autumn.json   |  3 ++
>  .../botania/recipes/runic_altar/earth.json    |  3 ++
>  .../botania/recipes/runic_altar/envy.json     |  3 ++
>  .../botania/recipes/runic_altar/fire.json     |  3 ++

Allows dynamic switching of the crafty crate mode

---
A separate problem that needs solving is adding a pattern item for
clearing the pattern (all blanks). Not hard but would involve me editing
textures which I don't want to do right now. So someone else can do it.

 Xplat/src/main/java/vazkii/botania/common/block/BotaniaBlocks.java                                |  10 ++
 Xplat/src/main/java/vazkii/botania/common/block/dispenser/CraftyCratePatternDispenseBehavior.java |  37 ++++++++++
 2 files changed, 47 insertions(+), 0 deletions(-)

diff --git a/Xplat/src/main/java/vazkii/botania/common/block/BotaniaBlocks.java b/Xplat/src/main/java/vazkii/botania/common/block/BotaniaBlocks.java
--- a/Xplat/src/main/java/vazkii/botania/common/block/BotaniaBlocks.java
+++ b/Xplat/src/main/java/vazkii/botania/common/block/BotaniaBlocks.java
[message trimmed]

you can go ahead and commit textures directly, since I don't have
useful feedback to give usually :P

Committed, thanks