Seattle, WA
Interests: systems programming, Minecraft modding, Touhou Project
From Vincent Lee to ~williewillus/violet-moon-announce
Version 1.19.2-440 of Botania, a tech mod themed around natural magic, has been released. What's New ========== This is forecast to be the final 1.19.2 release as we start porting to 1.19.3 and 1.19.4 in anticipation for 1.20 in a few weeks. Some highlights: - The Worldshaper's Sextant can generate 3d spheres - Orechid's JEI/EMI/REI integration now shows percentage chances for
From Vincent Lee to ~williewillus/violet-moon
Likely a regression from the tag migration. Closes #4379 diff --git a/Xplat/src/main/java/vazkii/botania/common/item/HornItem.java b/Xplat/src/main/java/vazkii/botania/common/item/HornItem.java --- a/Xplat/src/main/java/vazkii/botania/common/item/HornItem.java +++ b/Xplat/src/main/java/vazkii/botania/common/item/HornItem.java @@ -20,6 +20,7 @@ import net.minecraft.world.item.UseAnim; import net.minecraft.world.level.Level; import net.minecraft.world.level.block.BushBlock; import net.minecraft.world.level.block.LeavesBlock; import net.minecraft.world.level.block.entity.BlockEntity; import net.minecraft.world.level.block.state.BlockState; @@ -82,8 +83,14 @@ [message trimmed]
From Vincent Lee to ~williewillus/violet-moon
No functional change, refactor for next commit diff --git a/Xplat/src/main/java/vazkii/botania/common/item/HornItem.java b/Xplat/src/main/java/vazkii/botania/common/item/HornItem.java --- a/Xplat/src/main/java/vazkii/botania/common/item/HornItem.java +++ b/Xplat/src/main/java/vazkii/botania/common/item/HornItem.java @@ -19,7 +19,6 @@ import net.minecraft.world.item.ItemUtils; import net.minecraft.world.item.UseAnim; import net.minecraft.world.level.Level; import net.minecraft.world.level.block.Block; import net.minecraft.world.level.block.BushBlock; import net.minecraft.world.level.block.entity.BlockEntity; import net.minecraft.world.level.block.state.BlockState; @@ -70,6 +69,27 @@ [message trimmed]
From Vincent Lee to ~williewillus/violet-moon
This patch seems malformed somehow, git am and sl import both don't like, and Sourcehut seems to not recognize it. It appears the last hunk of TooltipHandler is missing a line somehow. However, this seems like it works. Ok for me to commit. There's a couple cleanups I want to do before releasing, and the test book creative tab stuff needs to be fixed, but I can do that in tree after you commit this. Artemis System <theartemissystem@gmail.com> writes: > --- > There is something wrong with the next/prev buttons, sometimes they seem to > "get stuck" and their tooltip always renders. I didn't have time to look into
From Vincent Lee to ~williewillus/violet-moon
Shaders are still loaded for error-checking, but Botania shaders will be replaced with the vanilla shader they were based on if useShaders is off. Starfield is exempt since its whole effect relies on the shader. diff --git a/Fabric/src/main/java/vazkii/botania/fabric/FiberBotaniaConfig.java b/Fabric/src/main/java/vazkii/botania/fabric/FiberBotaniaConfig.java --- a/Fabric/src/main/java/vazkii/botania/fabric/FiberBotaniaConfig.java +++ b/Fabric/src/main/java/vazkii/botania/fabric/FiberBotaniaConfig.java @@ -86,9 +86,14 @@ public final PropertyMirror<Boolean> debugInfo = PropertyMirror.create(BOOLEAN); public final PropertyMirror<Boolean> referencesEnabled = PropertyMirror.create(BOOLEAN); public final PropertyMirror<Boolean> splashesEnabled = PropertyMirror.create(BOOLEAN); public final PropertyMirror<Boolean> useShaders = PropertyMirror.create(BOOLEAN); [message trimmed]
From Vincent Lee to ~williewillus/violet-moon
Closes #4364 --- This patch was sent from Sapling as I'm trying it out. It's still a bit jank for email workflow though so excuse any formatting errors. Xplat/src/main/java/vazkii/botania/common/block/flower/generating/FluidGeneratorBlockEntity.java | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/Xplat/src/main/java/vazkii/botania/common/block/flower/generating/FluidGeneratorBlockEntity.java b/Xplat/src/main/java/vazkii/botania/common/block/flower/generating/FluidGeneratorBlockEntity.java --- a/Xplat/src/main/java/vazkii/botania/common/block/flower/generating/FluidGeneratorBlockEntity.java +++ b/Xplat/src/main/java/vazkii/botania/common/block/flower/generating/FluidGeneratorBlockEntity.java @@ -101,6 +101,7 @@ cooldown = getCooldownTime(false); [message trimmed]
From Vincent Lee to ~williewillus/violet-moon
Closes #4264
---
Dependency order is now:
BotaniaAPI/BotaniaBrews -> XplatAbstractions -> internal RegistryHolder
.../botania/fabric/xplat/FabricXplatImpl.java | 11 +++++++++--
.../vazkii/botania/forge/xplat/ForgeXplatImpl.java | 13 +++++++++----
.../vazkii/botania/common/brew/BotaniaBrews.java | 2 +-
.../vazkii/botania/common/impl/BotaniaAPIImpl.java | 4 ++--
.../vazkii/botania/xplat/XplatAbstractions.java | 2 +-
5 files changed, 22 insertions(+), 10 deletions(-)
diff --git a/Fabric/src/main/java/vazkii/botania/fabric/xplat/FabricXplatImpl.java b/Fabric/src/main/java/vazkii/botania/fabric/xplat/FabricXplatImpl.java
index 2d27174bc..d5c1d40f0 100644
[message trimmed]
From Vincent Lee to ~williewillus/violet-moon
Kludgy fix but can't think of anything better for now. Closes #4348 --- .../botania/common/entity/ManaBurstEntity.java | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/Xplat/src/main/java/vazkii/botania/common/entity/ManaBurstEntity.java b/Xplat/src/main/java/vazkii/botania/common/entity/ManaBurstEntity.java index 900073a90..af3c02189 100644 --- a/Xplat/src/main/java/vazkii/botania/common/entity/ManaBurstEntity.java +++ b/Xplat/src/main/java/vazkii/botania/common/entity/ManaBurstEntity.java @@ -465,6 +465,21 @@ public float getParticleSize() { return (float) getMana() / (float) getStartingMana(); } [message trimmed]
From Vincent Lee to ~williewillus/violet-moon
Closes #4355 --- .../java/vazkii/botania/common/item/lens/KindleLens.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Xplat/src/main/java/vazkii/botania/common/item/lens/KindleLens.java b/Xplat/src/main/java/vazkii/botania/common/item/lens/KindleLens.java index 00ca02959..72c73ed25 100644 --- a/Xplat/src/main/java/vazkii/botania/common/item/lens/KindleLens.java +++ b/Xplat/src/main/java/vazkii/botania/common/item/lens/KindleLens.java @@ -12,6 +12,7 @@ import net.minecraft.core.Direction; import net.minecraft.world.entity.Entity; import net.minecraft.world.item.ItemStack; import net.minecraft.world.level.block.BaseFireBlock;[message trimmed]
From Vincent Lee to ~williewillus/violet-moon
lgtm, but check two minor nits below before commiting Artemis System <theartemissystem@gmail.com> writes: > --- > minor spelling mistake > .../java/vazkii/botania/client/gui/HUDHandler.java | 14 ++++++++++++++ > .../main/resources/assets/botania/lang/en_us.json | 1 + > web/changelog.md | 1 + > 3 files changed, 16 insertions(+) > > diff --git a/Xplat/src/main/java/vazkii/botania/client/gui/HUDHandler.java b/Xplat/src/main/java/vazkii/botania/client/gui/HUDHandler.java > index 9246d9057..2814144bf 100644