~williewillus

Seattle, WA

https://www.vincent-lee.net/

Interests: systems programming, Minecraft modding, Touhou Project

~williewillus/violet-moon

Last active 4 days ago

~williewillus/public-inbox

Last active 26 days ago

~williewillus/racket-libraries

Last active a month ago

~williewillus/blog-comments

Last active 4 months ago
View more

Recent activity

Re: [PATCH] Add impulse lens 30 days ago

From Vincent Lee to ~williewillus/violet-moon

wenming.yi@gmail.com writes:

> From: Alwinfy <20421383+Alwinfy@users.noreply.github.com>
>
> ---
>  .../botania/models/item/lens_impulse.json     |   7 +++
>  .../recipes/botania/lens_impulse.json         |  34 ++++++++++++
>  .../data/botania/recipes/lens_impulse.json    |  14 +++++
>  .../data/botania/tags/items/lens.json         |   1 +
>  .../vazkii/botania/common/item/ModItems.java  |   1 +
>  .../botania/common/item/lens/LensShove.java   |  52 ++++++++++++++++++
>  .../botania/common/lib/LibItemNames.java      |   1 +
>  .../botania/data/recipes/RecipeProvider.java  |   5 ++

[PATCH botania 3/3] Document redirective lens changes a month ago

From Vincent Lee to ~williewillus/violet-moon

---
 Xplat/src/main/resources/assets/botania/lang/en_us.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Xplat/src/main/resources/assets/botania/lang/en_us.json b/Xplat/src/main/resources/assets/botania/lang/en_us.json
index e5f004745..fb15f3157 100644
--- a/Xplat/src/main/resources/assets/botania/lang/en_us.json
+++ b/Xplat/src/main/resources/assets/botania/lang/en_us.json
@@ -1996,7 +1996,7 @@
  "botania.page.elvenLenses2": "Paintslinger Lens",
  "botania.page.elvenLenses3": "The $(item)Warp Lens$(0) is an interesting one. A burst under its effects that collides with a $(l:ender/piston_relay)$(item)Force Relay$(0)$(/l) will teleport to the target of said $(l:ender/piston_relay)$(item)Force Relay$(0)$(/l), maintaining its momentum, but making its $(thing)Mana$(0) irrecoverable.$(p)Furthermore, when it's combined with a $(item)Bore Lens$(0) (the $(item)Bore Lens$(0) must be first), it'll prevent bursts from breaking $(l:ender/piston_relay)$(item)Force Relays$(0)$(/l) or $(item)Pistons$(0), and teleport any blocks broken by the $(item)Bore Lens$(0) to the burst's origin.",
  "botania.page.elvenLenses4": "Warp Lens",
  "botania.page.elvenLenses5": "The $(item)Redirective Lens$(0) will only take effect when fired from a $(l:mana/spreader)$(item)Mana Spreader$(0)$(/l). Any burst under its effects that collides with a $(l:mana/spreader)$(item)Mana Spreader$(0)$(/l) will (apart from transferring $(thing)Mana$(0) like normal) make the receiving spreader point towards the one that fired the burst.",
  "botania.page.elvenLenses5": "A burst affected by the $(item)Redirective Lens$(0) will make any $(l:mana/spreader)$(item)Mana Spreaders$(0)$(/l) or entities it collides with face towards the block or entity that fired the burst.",
[message trimmed]

[PATCH botania 2/3] Redirect lens now works on entity targets a month ago

From Vincent Lee to ~williewillus/violet-moon

---
 .../common/item/lens/LensRedirect.java        | 67 ++++++++++---------
 1 file changed, 36 insertions(+), 31 deletions(-)

diff --git a/Xplat/src/main/java/vazkii/botania/common/item/lens/LensRedirect.java b/Xplat/src/main/java/vazkii/botania/common/item/lens/LensRedirect.java
index af3108007..a5c0b65e1 100644
--- a/Xplat/src/main/java/vazkii/botania/common/item/lens/LensRedirect.java
+++ b/Xplat/src/main/java/vazkii/botania/common/item/lens/LensRedirect.java
@@ -8,13 +8,10 @@
 */
package vazkii.botania.common.item.lens;

import net.minecraft.commands.arguments.EntityAnchorArgument;
import net.minecraft.core.BlockPos;
[message trimmed]

[PATCH botania 1/3] Redirect lens can now aim towards entity sources a month ago

From Vincent Lee to ~williewillus/violet-moon

---
 .../common/block/tile/mana/TileSpreader.java  |  2 +-
 .../common/item/lens/LensRedirect.java        | 53 +++++++++++++------
 2 files changed, 37 insertions(+), 18 deletions(-)

diff --git a/Xplat/src/main/java/vazkii/botania/common/block/tile/mana/TileSpreader.java b/Xplat/src/main/java/vazkii/botania/common/block/tile/mana/TileSpreader.java
index 146c3b7b4..132e0a772 100644
--- a/Xplat/src/main/java/vazkii/botania/common/block/tile/mana/TileSpreader.java
+++ b/Xplat/src/main/java/vazkii/botania/common/block/tile/mana/TileSpreader.java
@@ -728,7 +728,7 @@ public void mirror(Mirror mirror) {

	@Override
	public void commitRedirection() {
		checkForReceiver();
[message trimmed]

[PATCH botania 0/3] Redirective lens improvements a month ago

From Vincent Lee to ~williewillus/violet-moon

This patchset makes the redirect lens work on entities, in both the
source and target directions.
iow, entities hit by the burst now face the source, and entities
firing bursts now count as a "source".
Support for extra blocks besides spreaders is not in scope.

ok?

Vincent Lee (3):
  Redirect lens can now aim towards entity sources
  Redirect lens now works on entity targets
  Document redirective lens changes

 .../common/block/tile/mana/TileSpreader.java  |   2 +-

[PATCH lists.sr.ht v2] Fix jinja2 3.1 imports a month ago

From Vincent Lee to ~sircmpwn/sr.ht-dev

---
V2: Resubmission of previous email, but with proper patch subject prefix.

The same fix was applied to other services couple weeks back, but
lists seems to have been missed. With this patch, lists now starts
with Jinja2 >= 3.1.

 listssrht/blueprints/patches.py | 2 +-
 listssrht/filters.py            | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/listssrht/blueprints/patches.py b/listssrht/blueprints/patches.py
index e794373..60d655f 100644
--- a/listssrht/blueprints/patches.py
[message trimmed]

[lists.sr.ht] Fix jinja2 3.1 imports a month ago

From Vincent Lee to ~sircmpwn/sr.ht-dev

---
The same fix was applied to other services couple weeks back, but
lists seems to have been missed. With this patch, lists now starts
with Jinja2 >= 3.1.

 listssrht/blueprints/patches.py | 2 +-
 listssrht/filters.py            | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/listssrht/blueprints/patches.py b/listssrht/blueprints/patches.py
index e794373..60d655f 100644
--- a/listssrht/blueprints/patches.py
+++ b/listssrht/blueprints/patches.py
@@ -3,7 +3,7 @@ import email
[message trimmed]

Re: [PATCH] Wand of the Elven Forest a month ago

From Vincent Lee to ~williewillus/violet-moon

Applied this (and the previous), thanks!

As a tip, run `git config format.subjectPrefix "PATCH botania"`
in your local checkout so future patches you send start with [PATCH botania],
that way SourceHut knows which repo to run CI against.

artemisSystem <theartemissystem@gmail.com> writes:

> ---
> Adds a dreamwood wand (Wand of the Elven Forest), and slightly changes the texture for the dreamwood twig. Also fixes the working file for twig_wand.ase which still had the old palette.
>
>  .../fabric/FabricCommonInitializer.java       |   1 +
>  .../botania/forge/ForgeCommonInitializer.java |   3 +-

Re: Dependencies between patches 2 months ago

From Vincent Lee to ~sircmpwn/sr.ht-discuss

"Drew DeVault" <sir@cmpwn.com> writes:

> On Fri Apr 8, 2022 at 12:06 PM CEST, Simon Ser wrote:
>> I assume you mean s/base commit ID/patch ID/?
>
> We should probably store both. My answer is whichever answer is the
> correct one; I lack the context to judge. Whoever writes the patch
> should do the research.

Great, I filed hub ticket #85 to track this https://todo.sr.ht/~sircmpwn/hub.sr.ht/85

Dependencies between patches 2 months ago

From Vincent Lee to ~sircmpwn/sr.ht-discuss

Hey all, just wanted to float an idea I mentioned on IRC a few weeks
back. Currently, patchsets sent to lists are assumed to apply directly to
trunk, and builds will attempt to do so.

This doesn't really work when you have patchsets that depend on other
patchsets, e.g. if you're working on a large, complex feature that
requires multiple patchsets each containing multiple commits.

GitHub fails miserably at this, forcing contributors to make multiple
pull-requests out of the same branch (which makes review difficult as
commits of the earlier PR's show up in the later PR's as well), or give
up and make one massive monster PR.