~williewillus/violet-moon

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
2 2

[PATCH botania] Fix fuelcap in Endo entry & add bit on managen

Details
Message ID
<20231004171115.10942-1-actuallyadarsh@gmail.com>
DKIM signature
missing
Download raw message
Patch: +7 -2
Lexicon endoflame entry now displays correct fuel cap of two coal blocks and somewhat quantifies how little mana it produces. Added a page to Generating Flora stating the link between automation complexity and increased managen.
---
 Xplat/src/main/resources/assets/botania/lang/en_us.json      | 5 +++--
 .../lexicon/en_us/entries/generating_flowers/intro.json      | 4 ++++
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/Xplat/src/main/resources/assets/botania/lang/en_us.json b/Xplat/src/main/resources/assets/botania/lang/en_us.json
index b996f2efe..946ca0973 100644
--- a/Xplat/src/main/resources/assets/botania/lang/en_us.json
+++ b/Xplat/src/main/resources/assets/botania/lang/en_us.json
@@ -2288,11 +2288,12 @@
  "botania.page.gIntro1": "All $(thing)Generating Flora$(0), like their $(thing)Functional$(0) brethren, can hold a small internal buffer of $(thing)Mana$(0).$(p)$(thing)Generating Flora$(0) will automatically output to the closest nearby $(l:mana/spreader)$(item)Mana Spreader$(0)$(/l).",
  "botania.page.gIntro2": "These flowers bind to one $(l:mana/spreader)$(item)Mana Spreader$(0)$(/l) at a time for $(thing)Mana$(0) output. They'll bind to the nearest spreader present at the time of their placement (or the nearest placed afterward, if none were in range), and must be re-bound to another spreader with a wand in $(thing)Bind Mode$(0), if so desired.",
  "botania.page.gIntro3": "Choosing your first $(thing)Generating Flower$(0) is a pretty simple task; the simplest two choices for any fledgling botanist are the $(l:generating_flowers/endoflame)$(item)Endoflame$(0)$(/l) and the $(l:generating_flowers/hydroangeas)$(item)Hydroangeas$(0)$(/l).$(p)The former uses $(item)Coal$(0) or other fuel sources to generate $(thing)Mana$(0). The latter uses $(item)Water$(0) sources for the same task, but decays after about three days.",
  "botania.page.gIntro4": "Later on, you may wish to branch out to other $(thing)Generating Flora$(0). Flowers that require more complex infrastructure to automate typically produce more $(thing)Mana$(0).",

  "botania.entry.endoflame": "Endoflame",
  "botania.tagline.endoflame": "Mana from fuel",
  "botania.page.endoflame0": "The $(item)Endoflame$(0) is a very rudimentary $(thing)generating flower$(0); it'll absorb any combustible items or blocks dropped on the nearby vicinity, one at a time, and burn through them to generate $(thing)Mana$(0).$(p)The amount of time it takes to burn through an item is roughly half of the time a $(item)Furnace$(0) would.",
  "botania.page.endoflame1": "There're a few small caveats though: the $(item)Endoflame$(0) will not burn anything that leave byproducts in $(item)Furnaces$(0) (e.g. $(item)Lava Buckets$(0), which leave $(item)Buckets$(0) behind).$(p)Furthermore, the flower can only burn around four $(item)Block of Coal$(0)s' worth of fuel at once. If any single fuel item with a longer burn time is used, its full efficiency will be lost.",
  "botania.page.endoflame0": "The $(item)Endoflame$(0) is a very rudimentary $(thing)generating flower$(0); it'll absorb any combustible items or blocks dropped on the nearby vicinity, one at a time, and burn through them to generate a trickle of $(thing)Mana$(0).$(p)The amount of time it takes to burn through an item is roughly half of the time a $(item)Furnace$(0) would.",
  "botania.page.endoflame1": "There're a few small caveats though: the $(item)Endoflame$(0) will not burn anything that leave byproducts in $(item)Furnaces$(0) (e.g. $(item)Lava Buckets$(0), which leave $(item)Buckets$(0) behind).$(p)Furthermore, the flower can only burn around two $(item)Block of Coal$(0)s' worth of fuel at once. If any single fuel item with a longer burn time is used, its full efficiency will be lost.",
  "botania.page.endoflame3": "As the $(item)Endoflame$(0) is often a botanist's first foray into proper automatable $(thing)Generating Flora$(0), it shouldn't be run manually forever. As the flower requires dropped items, an $(l:devices/open_crate)$(item)Open Crate$(0)$(/l) (found in the $(thing)Natural Apparatus$(0) section of this book) and some sort of output limiter (a timer or pressure plate) would be ideal for it.",
  "botania.page.endoflame2": "$(o)When arson becomes useful$().",

diff --git a/Xplat/src/main/resources/assets/botania/patchouli_books/lexicon/en_us/entries/generating_flowers/intro.json b/Xplat/src/main/resources/assets/botania/patchouli_books/lexicon/en_us/entries/generating_flowers/intro.json
index 2b13d0f97..e54ebf05c 100644
--- a/Xplat/src/main/resources/assets/botania/patchouli_books/lexicon/en_us/entries/generating_flowers/intro.json
+++ b/Xplat/src/main/resources/assets/botania/patchouli_books/lexicon/en_us/entries/generating_flowers/intro.json
@@ -20,6 +20,10 @@
    {
      "type": "text",
      "text": "botania.page.gIntro3"
    },
    {
      "type": "text",
      "text": "botania.page.gIntro4"
    }
  ]
}
-- 
2.34.1

[botania/patches/linux.yml] build failed

builds.sr.ht <builds@sr.ht>
Details
Message ID
<CVZTZLDMT813.1USCY5CC9DMQN@cirno2>
In-Reply-To
<20231004171115.10942-1-actuallyadarsh@gmail.com> (view parent)
DKIM signature
missing
Download raw message
botania/patches/linux.yml: FAILED in 17m51s

[Fix fuelcap in Endo entry & add bit on managen][0] from [Adarsh][1]

[0]: https://lists.sr.ht/~williewillus/violet-moon/patches/45365
[1]: actuallyadarsh@gmail.com

✗ #1068286 FAILED botania/patches/linux.yml https://builds.sr.ht/~williewillus/job/1068286
Details
Message ID
<87jzs0bl3x.fsf@vincent-lee.net>
In-Reply-To
<20231004171115.10942-1-actuallyadarsh@gmail.com> (view parent)
DKIM signature
missing
Download raw message
Committed, thanks
Reply to thread Export thread (mbox)