botania: Fix Kindle Lens not creating Soul Fire v1 APPLIED

Vincent Lee: 1
 Fix Kindle Lens not creating Soul Fire

 1 files changed, 3 insertions(+), 2 deletions(-)

[PATCH botania] Fix Kindle Lens not creating Soul Fire Export this patch

Closes #4355
---
 .../java/vazkii/botania/common/item/lens/KindleLens.java     | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Xplat/src/main/java/vazkii/botania/common/item/lens/KindleLens.java b/Xplat/src/main/java/vazkii/botania/common/item/lens/KindleLens.java
index 00ca02959..72c73ed25 100644
--- a/Xplat/src/main/java/vazkii/botania/common/item/lens/KindleLens.java
+++ b/Xplat/src/main/java/vazkii/botania/common/item/lens/KindleLens.java
@@ -12,6 +12,7 @@
 import net.minecraft.core.Direction;
 import net.minecraft.world.entity.Entity;
 import net.minecraft.world.item.ItemStack;
+import net.minecraft.world.level.block.BaseFireBlock;
 import net.minecraft.world.level.block.Blocks;
 import net.minecraft.world.level.block.state.BlockState;
 import net.minecraft.world.phys.BlockHitResult;
@@ -48,8 +49,8 @@ public boolean collideBurst(ManaBurst burst, HitResult rtr, boolean isManaBlock,
 			}
 			if (stateAtOffset.is(Blocks.NETHER_PORTAL)) {
 				entity.level.removeBlock(offPos, false);
-			} else if (stateAtOffset.isAir()) {
-				entity.level.setBlockAndUpdate(offPos, Blocks.FIRE.defaultBlockState());
+			} else if (BaseFireBlock.canBePlacedAt(entity.level, offPos, dir.getOpposite())) {
+				entity.level.setBlockAndUpdate(offPos, BaseFireBlock.getState(entity.level, offPos));
 			}
 		}
 
-- 
2.40.1

builds.sr.ht <builds@sr.ht>

1 year, 6 months ago

botania/patches/linux.yml: SUCCESS in 20m10s

[Fix Kindle Lens not creating Soul Fire][0] from [Vincent Lee][1]

[0]: https://lists.sr.ht/~williewillus/violet-moon/patches/41265
[1]: mailto:vincent@vincent-lee.net

✓ #992253 SUCCESS botania/patches/linux.yml https://builds.sr.ht/~williewillus/job/992253

Artemis System <theartemissystem@gmail.com>

1 year, 6 months ago

Looks good to me. I didn't apply to check it, but it's so simple that it
looks fine. Also seems to be the same way flint and steel does it, so
makes sense.