On Thu Mar 23, 2023 at 12:27 PM CET, Xavier wrote:
> A 22.03.2023 22:53, Oliver Lowe escrigué:
> > The text wraps because the area is divided into two sections:

> > 	<div class="row">
> > 		<div class="col-md-6">
> > 			Go package for controlling a Starlink Dishy device
> > 		</div>
> > 		<div class="col-md-6 licenses"></div>
> > 	</div>

> > Maybe that space is reserved for a future feature where a short
> > description of the project’s license is shown?
> Perhaps Drew or sr.ht could explain if it's true.

`:filter` was given twice in the "MESSAGE LIST COMMANDS" section of *aerc*(1),
both incomplete/wrong. Merge both to reference *aerc-search*(1) and say it
actually *filters* the message list.

References: https://todo.sr.ht/~rjarry/aerc/144
Signed-off-by: witcher <witcher@wiredspace.de>
Fixes: af63bd0188d13ecf00628c30f88d0ee06c07e500 ("doc: homogenize scdoc markup")
---
 CHANGELOG.md   | 2 ++
 doc/aerc.1.scd | 8 ++------
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 4081aa8..b36d45d 100644
[message trimmed]

On Mon Mar 6, 2023 at 1:46 PM CET, Hugo Osvaldo Barrera wrote:
> The lockfile includes the crate version, so you need to re-generate
> the lockfile when bumping it.

Looks like my workflow for bumping the version needs work... I assumed
it was included. It's included in v0.4.4.

Thanks for the information, and sorry for the trouble.

-- 
witcher

Sorry, this seems to have landed in my Spam folder for some reason.

Sure, I'll push a version bump in!

As I've just submitted my first patches and the code is still MIT
licensed, for completeness sake, I accept the license change of aerc
from MIT to GPL.

-- 
witcher

On Thu Mar 2, 2023 at 10:12 PM CET, Robin Jarry wrote:
> Nice work! Nitpick: for next time, please write your commit messages
> using imperative mood. See CONTRIBUTING.md for reference.
Ugh, missed that one, sorry. I'll keep it in mind!

> Applied. Thanks!
Thanks! :)

This patch automatically determines the signing account from the sender
of the email (i.e. the `From` email header).
To reflect this in the compose view after changing the `From` field, the
restriction in `updateCrypto()` to only run the update if the signing
key is empty has been lifted, so the key always gets updated when
calling `updateCrypt()`.
Additionally, a `Signer()` method has been added to the `Composer` to
avoid specifying the same logic twice; once in `updateCrypto()` and once
in `WriteMessage(...)`.
If the `From` header is not populated for any reason the `Signer()`
method falls back to the `From` field specified in `accounts.conf`.

Signed-off-by: witcher <witcher@wiredspace.de>
---
[message trimmed]

2af81a7430481b3aec40f6a794db8cde4e1e18e4 introduced a bug where if the
`pgp-opportunistic-encrypt` attribute is set to `true` and a new message
is composed, aerc would crash.
This is because no recipients have been specified, so
`checkEncryption()` would fail early and *not* call `updateCrypto()`,
which would then cause a segfault in `SetEncrypt()` later on.

To avoid this, when the function would have returned early, it instead
*doesn't* set `c.encrypt` to `true` and still calls `updateCrypto()`.

Signed-off-by: witcher <witcher@wiredspace.de>
---
 widgets/compose.go | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
[message trimmed]

On Thu Mar 2, 2023 at 3:42 PM CET, Tim Culverhouse wrote:
> Would you be willing to work on a patch? I can give some guidance if
> you need!

Gladly! I'll have a look at it in the evening and will get back to you
if needed!

On Thu Mar 2, 2023 at 2:57 PM CET, Robin Jarry wrote:
> witcher, Mar 01, 2023 at 20:11:
> Just a wild guess: can you ensure that you have the following:
>
>     [general]
>     pgp-provider = auto
>
> or
>
>     [general]
>     pgp-provider = gpg
>
> in ~/.config/aerc/aerc.conf ?