~witcher

Germany

https://wiredspace.de

Software Engineer. Mainly working with Rust. Interested in a lot of things but don't talk to me about Cryptocurrencies, Blockchain, and AI.

~witcher/rss-email-devel

Last active 6 months ago

~witcher/public-inbox

Last active 1 year, 1 month ago

~witcher/todotxt-discuss

Last active 1 year, 1 month ago

~witcher/todotxt-devel

Last active 1 year, 1 month ago

~witcher/todotxt-announce

Last active 1 year, 1 month ago

~witcher/rss-email-announce

Last active 1 year, 1 month ago
View more

Recent activity

Re: [PATCH aerc v2] ipc: wait for app to be ready before accepting commands 21 days ago

From Thomas Böhler to ~rjarry/aerc-devel

Tested-by: Thomas Böhler <witcher@wiredspace.de>
Reviewed-by: Thomas Böhler <witcher@wiredspace.de>

-- 
Thomas Böhler
https://wiredspace.de

Re: [PATCH aerc v2] commands: implement scrolloff 24 days ago

From Thomas Böhler to ~rjarry/aerc-devel

On Sun Jan 28, 2024 at 2:29 PM CET, Koni Marti wrote:
> Implement the :scrolloff command to mimic vim's scrolloff feature.
> Scrolloff sets a scroll offset for the scrollable widget of the message
> list. Define an alias :so for :scrolloff.
>
> A scroll offset for 5 lines can be enabled with
> 	:scrolloff 5
>
> and disabled by setting the scroll offset back to zero with
> 	:scrolloff 0

I like this, thanks for the patch!

> Add a 'zz' keybind that works as a toggle switch. If pressed once, the

[PATCH aerc] compose: don't attach key when removing signature 26 days ago

From Thomas Böhler to ~rjarry/aerc-devel

If pgp-attach-key is set in accounts.conf, the key is detached with
:detach and the signature removed with :sign, the key will be attached
again. When :sign is called again two keys will be attached instead of
one.

Fix this by not attaching a key if it cannot be detached.

Fixes: 9d90b70b4edf ("compose: refactor attachment handling")
Signed-off-by: Thomas Böhler <witcher@wiredspace.de>
---
 app/compose.go | 2 --
 1 file changed, 2 deletions(-)

diff --git a/app/compose.go b/app/compose.go
[message trimmed]

Re: [PATCH aerc] tabs: optimize switching by offsets 26 days ago

From Thomas Böhler to ~rjarry/aerc-devel

Reviewed-by: Thomas Böhler <witcher@wiredspace.de>
Tested-by: Thomas Böhler <witcher@wiredspace.de>

-- 
Thomas Böhler
https://wiredspace.de

Re: [PATCH aerc v3] compose: allow automatic attachment of signing key a month ago

From Thomas Böhler to ~rjarry/aerc-devel

Reviewed-by: Thomas Böhler <witcher@wiredspace.de>
Tested-by: Thomas Böhler <witcher@wiredspace.de>

-- 
Thomas Böhler
https://wiredspace.de

Re: [PATCH aerc v2] compose: allow automatic attachment of signing key a month ago

From Thomas Böhler to ~rjarry/aerc-devel

Looks like the problem is that c.crypto isn't initialized yet when
calling the c.SetAttachKey function.
A check for nil in c.SetAttachKey and subsequent call to c.updateCrypto
fixes this :)

-- 
Thomas Böhler
https://wiredspace.de

Re: [PATCH aerc v2] compose: allow automatic attachment of signing key a month ago

From Thomas Böhler to ~rjarry/aerc-devel

Getting a crash when composing with :compose

    [thomas@navi aerc]$ ./aerc
    
    aerc has encountered a critical error and has terminated. Please help us fix
    this by sending this log and the steps to reproduce the crash to:
    ~rjarry/aerc-devel@lists.sr.ht
    
    Thank you
    
    Version: 0.16.0-145-g617928a739cc +notmuch (go1.21.5 amd64 linux)
    
    This error was also written to: /tmp/aerc-crash-20240120-114614.log
    panic: runtime error: invalid memory address or nil pointer dereference [recovered]

Re: [PATCH aerc v3] aerc: add cli arguments for alternate config files a month ago

From Thomas Böhler to ~rjarry/aerc-devel

Looks like your v3 was a minute faster than my v2 review!

Reviewed-by: Thomas Böhler <witcher@wiredspace.de>

-- 
Thomas Böhler
https://wiredspace.de

Re: [PATCH aerc v2] aerc: add cli arguments for alternate config files a month ago

From Thomas Böhler to ~rjarry/aerc-devel

Looks good! There's a small thing you missed, though.

On Sat Jan 20, 2024 at 10:35 AM CET, Bence Ferdinandy wrote:
> Notes:
>     v2: - fail if file doesn't exist (also fails if it's a directory)
>         - shorter CLI args
>         - improved logic
>         - I'm not sure if Thomas Böhler's comment on XDG_CONFIG_HOME is
>           properly covered, but I guess will see :)

Sorry for the convoluted comment on that, but it seems like you figured
it out anyway! :)

> diff --git a/doc/aerc.1.scd b/doc/aerc.1.scd

Re: [PATCH aerc v1] aerc: add cli arguments for alternate config files a month ago

From Thomas Böhler to ~rjarry/aerc-devel

Hi, this is the first time I'm reviewing something. Please feel free to
point out anything that I should watch out for in a review that I'm not
already doing!

On Thu Jan 18, 2024 at 1:57 PM CET, Bence Ferdinandy wrote:
> -func parseAccounts(root string, accts []string) error {
> -	filename := path.Join(root, "accounts.conf")
> +func parseAccounts(root string, accts []string, confaccount string) error {
> +	filename := ""
> +	if confaccount != "" {
> +		if _, err := os.Stat(confaccount); errors.Is(err, os.ErrNotExist) {
> +			fmt.Printf("%s not found, falling back to default configuration file\n", filename)

`filename` always seems to be defined as `""` at this point, rendering