This thread contains a patchset. You're looking at the original emails,
but you may wish to use the patch review UI.
Review patch
2
2
[PATCH 1/2] Don't send invalid signatureHelp activeParameter values.
Leaving the arguments in place for when we implement the rest of the
feature.
---
src/fennel-ls/message.fnl | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/fennel-ls/message.fnl b/src/fennel-ls/message.fnl
index 8419f95..5b36af8 100644
--- a/src/fennel-ls/message.fnl
+++ b/src/fennel-ls/message.fnl
@@ -91,10 +91,9 @@ LSP json objects."
:kind ?kind
:edit {:changes {uri (diagnostic.quickfix)}}}))
-(λ symbol->signature-help [_server _file _call signature active-parameter]
+(λ symbol->signature-help [_server _file _call signature _active-parameter]
{:signatures [signature]
- :activeSignature 0
- :activeParameter active-parameter})
+ :activeSignature 0})
(λ multisym->range [server file ast n]
(let [spl (utils.multi-sym-split ast)
--
2.39.5 (Apple Git-154)
[PATCH 2/2] Update compiler diagnostics to follow the spec.
---
src/fennel-ls/compiler.fnl | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/fennel-ls/compiler.fnl b/src/fennel-ls/compiler.fnl
index 1780a69..13fb0e9 100644
--- a/src/fennel-ls/compiler.fnl
+++ b/src/fennel-ls/compiler.fnl
@@ -305,8 +305,7 @@ identifiers are declared / referenced in which places."
{:range range
:message msg
:severity message.severity.ERROR
- :code 201
- :codeDescription "compiler error"}))
+ :code :compiler-error}))
(if (attempt-to-recover! msg ast)
true
(do
@@ -320,8 +319,7 @@ identifiers are declared / referenced in which places."
{:range range
:message msg
:severity message.severity.ERROR
- :code 101
- :codeDescription "parse error"}))
+ :code :parse-error}))
(if (attempt-to-recover! msg)
true
(do
--
2.39.5 (Apple Git-154)
Re: [PATCH 2/2] Update compiler diagnostics to follow the spec.
Thanks; I've pushed this out and also the no-arguments one.
-Phil