From y0ast to ~sircmpwn/aerc
This sadly breaks sending, will send an updated patch.
From y0ast to ~sircmpwn/aerc
--- Currently whenever the sendmail command fails, aerc has no idea and will happily say everything is fine and copy the email to the SENT folder. This patch adds proper error propagation and shows an error in the ui that something has gone wrong with the send. commands/compose/send.go | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/commands/compose/send.go b/commands/compose/send.go index dd7ece9..1e0a3ce 100644 --- a/commands/compose/send.go +++ b/commands/compose/send.go @@ -232,9 +232,16 @@ func (Send) Execute(aerc *widgets.Aerc, args []string) error { [message trimmed]
From y0ast to ~sircmpwn/aerc
--- Implemented as discussed on IRC widgets/msgviewer.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/widgets/msgviewer.go b/widgets/msgviewer.go index 587959b..6c69577 100644 --- a/widgets/msgviewer.go +++ b/widgets/msgviewer.go @@ -586,7 +586,7 @@ func (pv *PartViewer) attemptCopy() { } go func() { pv.writeMailHeaders() [message trimmed]
From y0ast to ~sircmpwn/aerc
--- Change as requested. widgets/msglist.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/widgets/msglist.go b/widgets/msglist.go index e38dd9e..09b0868 100644 --- a/widgets/msglist.go +++ b/widgets/msglist.go @@ -125,7 +125,10 @@ func (ml *MessageList) Draw(ctx *ui.Context) { flagged = true } } [message trimmed]
From y0ast to ~sircmpwn/aerc
msglist_read in the stylesets is currently ignored, this patch fixes that. --- widgets/msglist.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/widgets/msglist.go b/widgets/msglist.go index e38dd9e..dd52c84 100644 --- a/widgets/msglist.go +++ b/widgets/msglist.go @@ -125,6 +125,11 @@ func (ml *MessageList) Draw(ctx *ui.Context) { flagged = true } [message trimmed]
From y0ast to ~sircmpwn/aerc
---
Currently, at least in imap, when doing reply-all to a message sent from
gmail (others could be affected to) with no emails in To or CC (only
bcc) the header contains "undisclosed-recipients:;". This gets parsed by
go-imap as "<undisclosed-recipients@>, <@>" (so actually two
addresses!). If we do reply all, aerc actually adds these malformed
emails to the To: field.
This patch adds an extra filter to see if emails are parseable (I
believe From and ReplyTo cannot be malformed so the filter is not
applied there).
This proposed solution is quite ugly. I think the correct behaviour
could be for go-imap to parse "undisclosed-recipients:;" as a name, and
[message trimmed]
From y0ast to ~sircmpwn/aerc
--- As requested on the previous patch, I've messaged upstream to make a release of tcell which they kindly did. go.mod | 5 +---- go.sum | 8 +++----- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/go.mod b/go.mod index 1e30aba..54db849 100644 --- a/go.mod +++ b/go.mod @@ -15,14 +15,13 @@ require ( github.com/emersion/go-sasl v0.0.0-20191210011802-430746ea8b9b [message trimmed]
From to ~sircmpwn/aerc
On Fri Aug 21, 2020 at 4:57 PM BST, Reto wrote:
> How "hard" is your opinion here?
Fair enough! Not hard at all, happy to follow your preference.
From to ~sircmpwn/aerc
On Thu Aug 20, 2020 at 8:56 PM BST, Reto Brunner wrote: > From: y0ast <joost@joo.st> > > We infer the correct From using the To: and Cc: field of the email that > we reply to. > --- > commands/msg/reply.go | 25 ++++++++++++++++++++++++- > config/config.go | 3 +++ > doc/aerc-config.5.scd | 7 +++++++ > 3 files changed, 34 insertions(+), 1 deletion(-) > > diff --git a/commands/msg/reply.go b/commands/msg/reply.go > index 7181e1e..8cca2b1 100644 > --- a/commands/msg/reply.go
From to ~sircmpwn/aerc
On Thu Aug 20, 2020 at 8:45 AM BST, Reto Brunner wrote: > From: y0ast <joost@joo.st> > > We infer the correct From using the To: and Cc: field of the email that > we reply to. > --- > commands/msg/reply.go | 25 ++++++++++++++++++++++++- > config/config.go | 3 +++ > doc/aerc-config.5.scd | 7 +++++++ > 3 files changed, 34 insertions(+), 1 deletion(-) > > diff --git a/commands/msg/reply.go b/commands/msg/reply.go > index 2ab12a7..c2cd6a7 100644 > --- a/commands/msg/reply.go