Russia (GMT+3)
Compiler guy. I like C, Rust and Go. Allergic to C++
yyp on Libera.Chat and OFTCFrom Alexey Yerin to ~sircmpwn/hare-dev
On Thu May 26, 2022 at 6:56 PM MSK, Umar Getagazov wrote:
> +if (uri.host is net::ip::addr || len(uri.host as str) > 0) {
I wonder if we should add net::uri::has_host() for this.
From Alexey Yerin to ~sircmpwn/alpine-aports
--- community/tut/APKBUILD | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/community/tut/APKBUILD b/community/tut/APKBUILD index e5b3780ce0..883a906e47 100644 --- a/community/tut/APKBUILD +++ b/community/tut/APKBUILD @@ -1,7 +1,7 @@ # Contributor: Alexey Yerin <yyp@disroot.org> # Maintainer: Alexey Yerin <yyp@disroot.org> pkgname=tut pkgver=1.0.5 pkgver=1.0.9 [message trimmed]
From Alexey Yerin to ~sircmpwn/hare-dev
On Tue May 17, 2022 at 2:28 PM MSK, Tom Lebreux wrote: > On 2022-05-17 04:42, Alexey Yerin wrote: > > I think we should do roundtrip tests instead - parsing the URI, > > validating its fields, and checking if the same string comes back after > > fmt(). > > I thought of this but for cases like > > https://git%2esr.ht/~sircmpw%6e/hare#Build%20status > > I am not sure it is supposed to roundtrip. According to the test that's > already there, it's supposed to parse the host as git.sr.ht. So I > figured it was better to write separate tests for all. >
From Alexey Yerin to ~sircmpwn/hare-dev
I think we should do roundtrip tests instead - parsing the URI, validating its fields, and checking if the same string comes back after fmt().
From Alexey Yerin to ~sircmpwn/hare-dev
On Wed May 11, 2022 at 10:14 PM MSK, Edin Taric wrote: > Signed-off-by: Edin Taric <unicorn@regrow.earth> > --- > encoding/hex/hex.ha | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git a/encoding/hex/hex.ha b/encoding/hex/hex.ha > index 681b96f0..acc27d4b 100644 > --- a/encoding/hex/hex.ha > +++ b/encoding/hex/hex.ha > @@ -76,13 +76,28 @@ export fn encodestr(in: []u8) str = { > return strio::string(&out); > }; >
From Alexey Yerin to ~sircmpwn/alpine-aports
--- community/tut/APKBUILD | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/community/tut/APKBUILD b/community/tut/APKBUILD index 0b75c0a2f4..4748e39586 100644 --- a/community/tut/APKBUILD +++ b/community/tut/APKBUILD @@ -1,7 +1,7 @@ # Contributor: Alexey Yerin <yyp@disroot.org> # Maintainer: Alexey Yerin <yyp@disroot.org> pkgname=tut pkgver=1.0.3 pkgver=1.0.5 [message trimmed]
From Alexey Yerin to ~sircmpwn/alpine-aports
--- community/tut/APKBUILD | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/community/tut/APKBUILD b/community/tut/APKBUILD index 4db0e06c35..0b75c0a2f4 100644 --- a/community/tut/APKBUILD +++ b/community/tut/APKBUILD @@ -1,7 +1,7 @@ # Contributor: Alexey Yerin <yyp@disroot.org> # Maintainer: Alexey Yerin <yyp@disroot.org> pkgname=tut pkgver=1.0.0 pkgver=1.0.3 [message trimmed]
From Alexey Yerin to ~sircmpwn/alpine-aports
--- community/tut/APKBUILD | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/community/tut/APKBUILD b/community/tut/APKBUILD index 92065ccd9a..4db0e06c35 100644 --- a/community/tut/APKBUILD +++ b/community/tut/APKBUILD @@ -1,7 +1,7 @@ # Contributor: Alexey Yerin <yyp@disroot.org> # Maintainer: Alexey Yerin <yyp@disroot.org> pkgname=tut pkgver=0.0.46 pkgver=1.0.0 [message trimmed]
From Alexey Yerin to ~sircmpwn/hare-dev
On Wed May 4, 2022 at 9:51 PM MSK, Alexey Yerin wrote: > > + for (let i = 0z; i < len(id1); i += 1) > > + if (strings::compare(id1[i], id2[i]) != 0) > > + return false; > > strings::compare is not necessary here, you can just use > id1[i] != id2[i]. Hm, actually, the custom compare function is not needed either since ast::ident_eq is a thing already.
From Alexey Yerin to ~sircmpwn/hare-dev
On Wed May 4, 2022 at 9:42 PM MSK, Nikola wrote: > This is a fix for #679. Instead of this, you can use a standard commit trailer to also automatically close the ticket: Fixes: https://todo.sr.ht/~sircmpwn/hare/679 > + for (let i = 0z; i < len(id1); i += 1) > + if (strings::compare(id1[i], id2[i]) != 0) > + return false; strings::compare is not necessary here, you can just use id1[i] != id2[i].